From 86e8effdaf39a25efaee984f5b1348f0164d9f66 Mon Sep 17 00:00:00 2001 From: The Magician Date: Mon, 20 Mar 2023 10:45:05 -0700 Subject: [PATCH] update maxItems (#7487) (#5346) * update maxItems * update description --------- Signed-off-by: Modular Magician Co-authored-by: Edward Sun --- .changelog/7487.txt | 3 +++ .../resource_network_services_edge_cache_origin.go | 4 ++-- .../resource_network_services_edge_cache_service.go | 12 ++++++------ .../network_services_edge_cache_origin.html.markdown | 2 +- 4 files changed, 12 insertions(+), 9 deletions(-) create mode 100644 .changelog/7487.txt diff --git a/.changelog/7487.txt b/.changelog/7487.txt new file mode 100644 index 0000000000..f7912edab2 --- /dev/null +++ b/.changelog/7487.txt @@ -0,0 +1,3 @@ +```release-note:enhancement +networkservices: updated maxItems to 25 for fields `expose_headers`,`allow_headers`, `request_header_to_remove`, `request_header_to_add`, `response_header_to_add` and `response_header_to_remove` of `google_network_services_edge_cache_service` and `request_headers_to_add` of `google_network_services_edge_cache_origin` +``` diff --git a/google-beta/resource_network_services_edge_cache_origin.go b/google-beta/resource_network_services_edge_cache_origin.go index 1909ae4b17..983f61bc53 100644 --- a/google-beta/resource_network_services_edge_cache_origin.go +++ b/google-beta/resource_network_services_edge_cache_origin.go @@ -147,9 +147,9 @@ headers, for request handled by this origin.`, Optional: true, Description: `Describes a header to add. -You may add a maximum of 5 request headers.`, +You may add a maximum of 25 request headers.`, MinItems: 1, - MaxItems: 5, + MaxItems: 25, Elem: &schema.Resource{ Schema: map[string]*schema.Schema{ "header_name": { diff --git a/google-beta/resource_network_services_edge_cache_service.go b/google-beta/resource_network_services_edge_cache_service.go index 51a1658e66..fcb7f40233 100644 --- a/google-beta/resource_network_services_edge_cache_service.go +++ b/google-beta/resource_network_services_edge_cache_service.go @@ -263,7 +263,7 @@ to which you could add rules numbered from 6 to 8, 10 to 11, and 13 to 15 in the Optional: true, Description: `Describes a header to add.`, MinItems: 1, - MaxItems: 5, + MaxItems: 25, Elem: &schema.Resource{ Schema: map[string]*schema.Schema{ "header_name": { @@ -290,7 +290,7 @@ to which you could add rules numbered from 6 to 8, 10 to 11, and 13 to 15 in the Optional: true, Description: `A list of header names for headers that need to be removed from the request prior to forwarding the request to the origin.`, MinItems: 1, - MaxItems: 10, + MaxItems: 25, Elem: &schema.Resource{ Schema: map[string]*schema.Schema{ "header_name": { @@ -308,7 +308,7 @@ to which you could add rules numbered from 6 to 8, 10 to 11, and 13 to 15 in the Response headers are only sent to the client, and do not have an effect on the cache serving the response.`, MinItems: 1, - MaxItems: 5, + MaxItems: 25, Elem: &schema.Resource{ Schema: map[string]*schema.Schema{ "header_name": { @@ -335,7 +335,7 @@ Response headers are only sent to the client, and do not have an effect on the c Optional: true, Description: `A list of header names for headers that need to be removed from the request prior to forwarding the request to the origin.`, MinItems: 1, - MaxItems: 10, + MaxItems: 25, Elem: &schema.Resource{ Schema: map[string]*schema.Schema{ "header_name": { @@ -729,7 +729,7 @@ This translates to the Access-Control-Allow-Credentials response header.`, Type: schema.TypeList, Optional: true, Description: `Specifies the content for the Access-Control-Allow-Headers response header.`, - MaxItems: 5, + MaxItems: 25, Elem: &schema.Schema{ Type: schema.TypeString, }, @@ -763,7 +763,7 @@ This translates to the Access-Control-Allow-Origin response header.`, Type: schema.TypeList, Optional: true, Description: `Specifies the content for the Access-Control-Allow-Headers response header.`, - MaxItems: 5, + MaxItems: 25, Elem: &schema.Schema{ Type: schema.TypeString, }, diff --git a/website/docs/r/network_services_edge_cache_origin.html.markdown b/website/docs/r/network_services_edge_cache_origin.html.markdown index e50fa3d0dd..5cbb8edb72 100644 --- a/website/docs/r/network_services_edge_cache_origin.html.markdown +++ b/website/docs/r/network_services_edge_cache_origin.html.markdown @@ -314,7 +314,7 @@ The following arguments are supported: * `request_headers_to_add` - (Optional) Describes a header to add. - You may add a maximum of 5 request headers. + You may add a maximum of 25 request headers. Structure is [documented below](#nested_request_headers_to_add).