From b02ab2dfecc8f8a394a7bbce61162e8c0f3f770c Mon Sep 17 00:00:00 2001 From: The Magician Date: Fri, 26 Aug 2022 12:01:26 -0700 Subject: [PATCH] fixing id for a data source (#6476) (#4636) Co-authored-by: Edward Sun Signed-off-by: Modular Magician Signed-off-by: Modular Magician Co-authored-by: Edward Sun --- .changelog/6476.txt | 3 +++ google-beta/data_source_google_compute_instance.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 .changelog/6476.txt diff --git a/.changelog/6476.txt b/.changelog/6476.txt new file mode 100644 index 0000000000..74d90dface --- /dev/null +++ b/.changelog/6476.txt @@ -0,0 +1,3 @@ +```release-note:bug +compute: fixed the `id` format of the data source `google_compute_instance` +``` diff --git a/google-beta/data_source_google_compute_instance.go b/google-beta/data_source_google_compute_instance.go index 789bd170a8..d1b9e252b9 100644 --- a/google-beta/data_source_google_compute_instance.go +++ b/google-beta/data_source_google_compute_instance.go @@ -191,6 +191,6 @@ func dataSourceGoogleComputeInstanceRead(d *schema.ResourceData, meta interface{ if err := d.Set("name", instance.Name); err != nil { return fmt.Errorf("Error setting name: %s", err) } - d.SetId(fmt.Sprintf("projects/%s/zones/%s/instances/%s", project, instance.Zone, instance.Name)) + d.SetId(fmt.Sprintf("projects/%s/zones/%s/instances/%s", project, GetResourceNameFromSelfLink(instance.Zone), instance.Name)) return nil }