From d1c6398c8bbcb0648c0c95dd98bd2e5c4f758530 Mon Sep 17 00:00:00 2001 From: Modular Magician Date: Mon, 9 Nov 2020 20:02:02 +0000 Subject: [PATCH] length check added before type assertion to avoid panic (#4184) Signed-off-by: Modular Magician --- .changelog/4184.txt | 4 ++++ google-beta/resource_storage_bucket.go | 3 +++ 2 files changed, 7 insertions(+) create mode 100644 .changelog/4184.txt diff --git a/.changelog/4184.txt b/.changelog/4184.txt new file mode 100644 index 0000000000..47364a2b8d --- /dev/null +++ b/.changelog/4184.txt @@ -0,0 +1,4 @@ +```release-note:bug +storage - added length check for `cors` for the resource `resource_storage_bucket` + +``` diff --git a/google-beta/resource_storage_bucket.go b/google-beta/resource_storage_bucket.go index 656cbb9ad2..18411c22b3 100644 --- a/google-beta/resource_storage_bucket.go +++ b/google-beta/resource_storage_bucket.go @@ -844,6 +844,9 @@ func resourceStorageBucketStateImporter(d *schema.ResourceData, meta interface{} func expandCors(configured []interface{}) []*storage.BucketCors { corsRules := make([]*storage.BucketCors, 0, len(configured)) + if len(corsRules) == 0 { + return nil + } for _, raw := range configured { data := raw.(map[string]interface{}) corsRule := storage.BucketCors{