From b11c9fbfb4104c7c1d1b75728529e79d81ceb728 Mon Sep 17 00:00:00 2001 From: Modular Magician Date: Tue, 7 Sep 2021 20:46:57 +0000 Subject: [PATCH] fixed a undetect change (#5178) Signed-off-by: Modular Magician --- .changelog/5178.txt | 3 +++ google-beta/resource_compute_security_policy.go | 2 +- google-beta/resource_gke_hub_feature_membership_test.go | 2 +- google-beta/resource_storage_bucket.go | 4 ++++ 4 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 .changelog/5178.txt diff --git a/.changelog/5178.txt b/.changelog/5178.txt new file mode 100644 index 0000000000..7c62afbf80 --- /dev/null +++ b/.changelog/5178.txt @@ -0,0 +1,3 @@ +```release-note:bug +storage: fixed a undetected change on `days_since_noncurrent_time` of `google_storage_bucket` +``` diff --git a/google-beta/resource_compute_security_policy.go b/google-beta/resource_compute_security_policy.go index 590a7ebd40..f842e34033 100644 --- a/google-beta/resource_compute_security_policy.go +++ b/google-beta/resource_compute_security_policy.go @@ -10,7 +10,7 @@ import ( "github.com/hashicorp/errwrap" "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema" "github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation" - "google.golang.org/api/compute/v0.beta" + compute "google.golang.org/api/compute/v0.beta" ) func resourceComputeSecurityPolicy() *schema.Resource { diff --git a/google-beta/resource_gke_hub_feature_membership_test.go b/google-beta/resource_gke_hub_feature_membership_test.go index 32fa84c196..9e1f2ea64d 100644 --- a/google-beta/resource_gke_hub_feature_membership_test.go +++ b/google-beta/resource_gke_hub_feature_membership_test.go @@ -5,7 +5,7 @@ import ( "fmt" "testing" - dcl "github.com/GoogleCloudPlatform/declarative-resource-client-library/dcl" + "github.com/GoogleCloudPlatform/declarative-resource-client-library/dcl" gkehub "github.com/GoogleCloudPlatform/declarative-resource-client-library/services/google/gkehub/beta" "github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource" "github.com/hashicorp/terraform-plugin-sdk/v2/terraform" diff --git a/google-beta/resource_storage_bucket.go b/google-beta/resource_storage_bucket.go index c8fcf4ecb5..348907497e 100644 --- a/google-beta/resource_storage_bucket.go +++ b/google-beta/resource_storage_bucket.go @@ -1319,6 +1319,10 @@ func resourceGCSBucketLifecycleRuleConditionHash(v interface{}) int { buf.WriteString(fmt.Sprintf("%d-", v.(int))) } + if v, ok := m["days_since_noncurrent_time"]; ok { + buf.WriteString(fmt.Sprintf("%d-", v.(int))) + } + if v, ok := m["created_before"]; ok { buf.WriteString(fmt.Sprintf("%s-", v.(string))) }