-
Notifications
You must be signed in to change notification settings - Fork 1.7k
/
common_diff_suppress_test.go
491 lines (467 loc) · 14.9 KB
/
common_diff_suppress_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0
// Contains common diff suppress functions.
package tpgresource
import "testing"
func TestOptionalPrefixSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
Prefix string
ExpectDiffSuppress bool
}{
"with same prefix": {
Old: "my-folder",
New: "folders/my-folder",
Prefix: "folders/",
ExpectDiffSuppress: true,
},
"with different prefix": {
Old: "folders/my-folder",
New: "organizations/my-folder",
Prefix: "folders/",
ExpectDiffSuppress: false,
},
"same without prefix": {
Old: "my-folder",
New: "my-folder",
Prefix: "folders/",
ExpectDiffSuppress: false,
},
"different without prefix": {
Old: "my-folder",
New: "my-new-folder",
Prefix: "folders/",
ExpectDiffSuppress: false,
},
}
for tn, tc := range cases {
if OptionalPrefixSuppress(tc.Prefix)("folder", tc.Old, tc.New, nil) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
}
}
func TestIgnoreMissingKeyInMap(t *testing.T) {
cases := map[string]struct {
Old, New string
Key string
ExpectDiffSuppress bool
}{
"missing key in map": {
Old: "",
New: "v1",
Key: "x-goog-version",
ExpectDiffSuppress: true,
},
"different values": {
Old: "v1",
New: "v2",
Key: "x-goog-version",
ExpectDiffSuppress: false,
},
"same values": {
Old: "v1",
New: "v1",
Key: "x-goog-version",
ExpectDiffSuppress: false,
},
}
for tn, tc := range cases {
if IgnoreMissingKeyInMap(tc.Key)("push_config.0.attributes."+tc.Key, tc.Old, tc.New, nil) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
}
}
func TestOptionalSurroundingSpacesSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
ExpectDiffSuppress bool
}{
"surrounding spaces": {
Old: "value",
New: " value ",
ExpectDiffSuppress: true,
},
"no surrounding spaces": {
Old: "value",
New: "value",
ExpectDiffSuppress: true,
},
"one space each": {
Old: " value",
New: "value ",
ExpectDiffSuppress: true,
},
"different values": {
Old: " different",
New: "values ",
ExpectDiffSuppress: false,
},
}
for tn, tc := range cases {
if OptionalSurroundingSpacesSuppress("filter", tc.Old, tc.New, nil) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
}
}
func TestCaseDiffSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
ExpectDiffSuppress bool
}{
"differents cases": {
Old: "Value",
New: "value",
ExpectDiffSuppress: true,
},
"different values": {
Old: "value",
New: "NewValue",
ExpectDiffSuppress: false,
},
"same cases": {
Old: "value",
New: "value",
ExpectDiffSuppress: true,
},
}
for tn, tc := range cases {
if CaseDiffSuppress("key", tc.Old, tc.New, nil) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
}
}
func TestPortRangeDiffSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
ExpectDiffSuppress bool
}{
"different single values": {
Old: "80-80",
New: "443",
ExpectDiffSuppress: false,
},
"different ranges": {
Old: "80-80",
New: "443-444",
ExpectDiffSuppress: false,
},
"same single values": {
Old: "80-80",
New: "80",
ExpectDiffSuppress: true,
},
"same ranges": {
Old: "80-80",
New: "80-80",
ExpectDiffSuppress: false,
},
}
for tn, tc := range cases {
if PortRangeDiffSuppress("ports", tc.Old, tc.New, nil) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
}
}
func TestLocationDiffSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
ExpectDiffSuppress bool
}{
"locations to zones": {
Old: "projects/x/locations/y/resource/z",
New: "projects/x/zones/y/resource/z",
ExpectDiffSuppress: true,
},
"regions to locations": {
Old: "projects/x/regions/y/resource/z",
New: "projects/x/locations/y/resource/z",
ExpectDiffSuppress: true,
},
"locations to locations": {
Old: "projects/x/locations/y/resource/z",
New: "projects/x/locations/y/resource/z",
ExpectDiffSuppress: false,
},
"zones to regions": {
Old: "projects/x/zones/y/resource/z",
New: "projects/x/regions/y/resource/z",
ExpectDiffSuppress: false,
},
"different locations": {
Old: "projects/x/locations/a/resource/z",
New: "projects/x/locations/b/resource/z",
ExpectDiffSuppress: false,
},
}
for tn, tc := range cases {
if LocationDiffSuppress("policy_uri", tc.Old, tc.New, nil) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
}
}
func TestAbsoluteDomainSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
ExpectDiffSuppress bool
}{
"new trailing dot": {
Old: "sslcert.tf-test.club",
New: "sslcert.tf-test.club.",
ExpectDiffSuppress: true,
},
"old trailing dot": {
Old: "sslcert.tf-test.club.",
New: "sslcert.tf-test.club",
ExpectDiffSuppress: true,
},
"same trailing dot": {
Old: "sslcert.tf-test.club.",
New: "sslcert.tf-test.club.",
ExpectDiffSuppress: false,
},
"different trailing dot": {
Old: "sslcert.tf-test.club.",
New: "sslcert.tf-test.clubs.",
ExpectDiffSuppress: false,
},
"different no trailing dot": {
Old: "sslcert.tf-test.club",
New: "sslcert.tf-test.clubs",
ExpectDiffSuppress: false,
},
}
for tn, tc := range cases {
if AbsoluteDomainSuppress("managed.0.domains.", tc.Old, tc.New, nil) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
}
}
func TestDurationDiffSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
ExpectDiffSuppress bool
}{
"different values": {
Old: "60s",
New: "65s",
ExpectDiffSuppress: false,
},
"same values": {
Old: "60s",
New: "60s",
ExpectDiffSuppress: true,
},
"different values, different formats": {
Old: "65s",
New: "60.0s",
ExpectDiffSuppress: false,
},
"same values, different formats": {
Old: "60.0s",
New: "60s",
ExpectDiffSuppress: true,
},
}
for tn, tc := range cases {
if DurationDiffSuppress("duration", tc.Old, tc.New, nil) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
}
}
func TestInternalIpDiffSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
ExpectDiffSuppress bool
}{
"same1 ipv6s": {
Old: "2600:1900:4020:31cd:8000:0:0:0",
New: "2600:1900:4020:31cd:8000::",
ExpectDiffSuppress: true,
},
"same2 ipv6s": {
Old: "2600:1900:4020:31cd:8000:0:0:0/96",
New: "2600:1900:4020:31cd:8000::/96",
ExpectDiffSuppress: true,
},
"same3 ipv6s": {
Old: "2600:1900:4020:31cd:8000:0:0:0/96",
New: "https://www.googleapis.com/compute/v1/projects/myproject/regions/us-central1/addresses/myaddress",
ExpectDiffSuppress: true,
},
"different1 ipv6s": {
Old: "2600:1900:4020:31cd:8000:0:0:0",
New: "2600:1900:4020:31cd:8001::",
ExpectDiffSuppress: false,
},
"different2 ipv6s": {
Old: "2600:1900:4020:31cd:8000:0:0:0",
New: "2600:1900:4020:31cd:8000:0:0:8000",
ExpectDiffSuppress: false,
},
"different3 ipv6s": {
Old: "2600:1900:4020:31cd:8000:0:0:0/96",
New: "2600:1900:4020:31cd:8001::/96",
ExpectDiffSuppress: false,
},
"different ipv4s": {
Old: "1.2.3.4",
New: "1.2.3.5",
ExpectDiffSuppress: false,
},
"same ipv4s": {
Old: "1.2.3.4",
New: "1.2.3.4",
ExpectDiffSuppress: true,
},
"ipv4 vs id": {
Old: "1.2.3.4",
New: "google_compute_address.my_ipv4_addr.address",
ExpectDiffSuppress: true,
},
"ipv6 vs id": {
Old: "2600:1900:4020:31cd:8000:0:0:0",
New: "google_compute_address.my_ipv6_addr.address",
ExpectDiffSuppress: true,
},
}
for tn, tc := range cases {
if InternalIpDiffSuppress("ipv4/v6_compare", tc.Old, tc.New, nil) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
}
}
func TestLastSlashDiffSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
ExpectDiffSuppress bool
}{
"slash to no slash": {
Old: "https://hello-rehvs75zla-uc.a.run.app/",
New: "https://hello-rehvs75zla-uc.a.run.app",
ExpectDiffSuppress: true,
},
"no slash to slash": {
Old: "https://hello-rehvs75zla-uc.a.run.app",
New: "https://hello-rehvs75zla-uc.a.run.app/",
ExpectDiffSuppress: true,
},
"slash to slash": {
Old: "https://hello-rehvs75zla-uc.a.run.app/",
New: "https://hello-rehvs75zla-uc.a.run.app/",
ExpectDiffSuppress: true,
},
"no slash to no slash": {
Old: "https://hello-rehvs75zla-uc.a.run.app",
New: "https://hello-rehvs75zla-uc.a.run.app",
ExpectDiffSuppress: true,
},
"different domains": {
Old: "https://x.a.run.app/",
New: "https://y.a.run.app",
ExpectDiffSuppress: false,
},
}
for tn, tc := range cases {
if LastSlashDiffSuppress("uri", tc.Old, tc.New, nil) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
}
}
func TestEmptyOrUnsetBlockDiffSuppress(t *testing.T) {
cases := map[string]struct {
Key, Old, New string
OldVal, NewVal interface{}
ExpectDiffSuppress bool
}{
"empty block vs. block containing empty string": {
Key: "example_block.#",
Old: "0",
New: "1",
OldVal: []interface{}{},
NewVal: []interface{}{map[string]interface{}{"empty_string": ""}},
ExpectDiffSuppress: true,
},
"empty block vs. block containing false bool": {
Key: "example_block.#",
Old: "0",
New: "1",
OldVal: []interface{}{},
NewVal: []interface{}{map[string]interface{}{"false_bool": false}},
ExpectDiffSuppress: true,
},
"empty block vs. block containing empty list": {
Key: "example_block.#",
Old: "0",
New: "1",
OldVal: []interface{}{},
NewVal: []interface{}{map[string]interface{}{"example_list": []interface{}{}}},
ExpectDiffSuppress: true,
},
// If a parent block returns an empty sub-block in lieu of nil or an empty map, the values of the undefined
// parent block and an empty, but defined block will be identical while the array count will have changed
"nested block, defined empty vs. undefined": {
Key: "example_block.#",
Old: "1",
New: "0",
OldVal: []interface{}{map[string]interface{}{"nested_block": []interface{}{}}},
NewVal: []interface{}{map[string]interface{}{"nested_block": []interface{}{}}},
ExpectDiffSuppress: true,
},
"nested block, defined empty vs. nil": {
Key: "node_pool_auto_config.#",
Old: "1",
New: "0",
OldVal: []interface{}{map[string]interface{}{"network_tags": []interface{}{}}},
NewVal: nil,
ExpectDiffSuppress: true,
},
"nested block, empty vs. non-empty list": {
Key: "node_pool_auto_config.#",
Old: "0",
New: "1",
OldVal: []interface{}{},
NewVal: []interface{}{map[string]interface{}{"network_tags": []interface{}{map[string]interface{}{"tags": []interface{}{"test-network-tag"}}}}},
ExpectDiffSuppress: false,
},
"nested block with nil list": {
Key: "node_pool_auto_config.#",
Old: "0",
New: "1",
OldVal: nil,
NewVal: []interface{}{map[string]interface{}{"network_tags": []interface{}{map[string]interface{}{"tags": nil}}}},
ExpectDiffSuppress: false,
},
"nested block with empty list": {
Key: "node_pool_auto_config.#",
Old: "0",
New: "1",
OldVal: nil,
NewVal: []interface{}{map[string]interface{}{"network_tags": []interface{}{map[string]interface{}{"tags": []interface{}{}}}}},
ExpectDiffSuppress: false,
},
"list inside nested optional block": {
Key: "node_pool_auto_config.0.network_tags.0.tags.#",
Old: "0",
New: "1",
OldVal: []interface{}{},
NewVal: []interface{}{"test-network-tag"},
ExpectDiffSuppress: false,
},
"list item inside optional block": {
Key: "node_pool_auto_config.0.network_tags.0.tags.0",
Old: "",
New: "test-network-tag",
OldVal: "",
NewVal: "test-network-tag",
ExpectDiffSuppress: false,
},
}
for tn, tc := range cases {
if EmptyOrUnsetBlockDiffSuppressLogic(tc.Key, tc.Old, tc.New, tc.OldVal, tc.NewVal) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSuppress)
}
if EmptyOrUnsetBlockDiffSuppressLogic(tc.Key, tc.New, tc.Old, tc.NewVal, tc.OldVal) != tc.ExpectDiffSuppress {
t.Fatalf("bad: %s (reverse check), '%s' => '%s' expect %t", tn, tc.New, tc.Old, tc.ExpectDiffSuppress)
}
}
}