From 7bbe743edb134a365271626c901eb6f2813132eb Mon Sep 17 00:00:00 2001 From: The Magician Date: Wed, 14 Dec 2022 10:31:46 -0800 Subject: [PATCH] Add Firebase AppleApp Data Source (#6876) (#13239) * Update api.yaml * Update api.yaml * Update api.yaml * Update api.yaml * Update terraform.yaml * Create firebase_apple_app_basic.tf.erb * Responding to tylerg-dev's comments * Fixing the failing TestAccFirebaseAppleApp_firebaseAppleAppBasicExample test * Add a handwritten sweeper to hard-delete the AppleApp * Fix typo in update_mask * Fix var name in test * Add delete request body * Change appId to app_id in the sweeper delete url * Use custom_delete for deleting the AppleApp resource * Update api.yaml * Remove the repeated block in terraform.api * Add a 5 sec in the post_delete template * Move the 5 sec delay to the custom delete code * Add "Optional" to the deletion_policy description. * Address melinath@ comments * Add a manual update test * Remove unnecessary randomness. Also, move attributes to the vars section so they show up in docs. * Update mmv1/products/firebase/terraform.yaml Co-authored-by: Stephen Lewis (Burrows) * Update mmv1/products/firebase/terraform.yaml Co-authored-by: Stephen Lewis (Burrows) * Update mmv1/products/firebase/terraform.yaml Co-authored-by: Stephen Lewis (Burrows) * Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_update_test.go.erb Co-authored-by: Stephen Lewis (Burrows) * Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_update_test.go.erb Co-authored-by: Stephen Lewis (Burrows) * Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_update_test.go.erb Co-authored-by: Stephen Lewis (Burrows) * Adding back the test_vars_overrides. * Add a Datasource for Firebase AppleApp * Fix lint warnings * Add documentations and fix the test * Update the test providers. * Remove the providers from the AppleApp datasource tests * Add GA tags to the data source test and rename it to .go.erb * Fix tabs in Datasource map. * Add randomness to bundle_id to avoid collision. * Responding to roaks3's comments * Remove ws from data_source_google_firebase_web_app.go.erb * Remove unneeded whitespaces from provider.go.erb Co-authored-by: Stephen Lewis (Burrows) Signed-off-by: Modular Magician Signed-off-by: Modular Magician Co-authored-by: Stephen Lewis (Burrows) --- .changelog/6876.txt | 3 + .../data_source_google_firebase_apple_app.go | 1 + ...a_source_google_firebase_apple_app_test.go | 1 + .../docs/d/firebase_android_app.html.markdown | 2 +- .../docs/d/firebase_apple_app.html.markdown | 57 +++++++++++++++++++ 5 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 .changelog/6876.txt create mode 100644 google/data_source_google_firebase_apple_app.go create mode 100644 google/data_source_google_firebase_apple_app_test.go create mode 100644 website/docs/d/firebase_apple_app.html.markdown diff --git a/.changelog/6876.txt b/.changelog/6876.txt new file mode 100644 index 00000000000..7728b818f9e --- /dev/null +++ b/.changelog/6876.txt @@ -0,0 +1,3 @@ +```release-note:new-datasource +`google_firebase_apple_app` +``` diff --git a/google/data_source_google_firebase_apple_app.go b/google/data_source_google_firebase_apple_app.go new file mode 100644 index 00000000000..71664db3c87 --- /dev/null +++ b/google/data_source_google_firebase_apple_app.go @@ -0,0 +1 @@ +package google diff --git a/google/data_source_google_firebase_apple_app_test.go b/google/data_source_google_firebase_apple_app_test.go new file mode 100644 index 00000000000..71664db3c87 --- /dev/null +++ b/google/data_source_google_firebase_apple_app_test.go @@ -0,0 +1 @@ +package google diff --git a/website/docs/d/firebase_android_app.html.markdown b/website/docs/d/firebase_android_app.html.markdown index da44365063f..6bf0657ffe6 100644 --- a/website/docs/d/firebase_android_app.html.markdown +++ b/website/docs/d/firebase_android_app.html.markdown @@ -20,7 +20,7 @@ The following arguments are supported: * `app_id` - (Required) - The app_ip of name of the Firebase androidApp. + The app_id of name of the Firebase androidApp. - - - diff --git a/website/docs/d/firebase_apple_app.html.markdown b/website/docs/d/firebase_apple_app.html.markdown new file mode 100644 index 00000000000..f98d653e5d6 --- /dev/null +++ b/website/docs/d/firebase_apple_app.html.markdown @@ -0,0 +1,57 @@ +--- +subcategory: "Firebase" +page_title: "Google: google_firebase_apple_app" +description: |- + A Google Cloud Firebase Apple application instance +--- + +# google\_firebase\_apple\_app + +A Google Cloud Firebase Apple application instance + +~> **Warning:** This resource is in beta, and should be used with the terraform-provider-google-beta provider. +See [Provider Versions](https://terraform.io/docs/providers/google/guides/provider_versions.html) for more details on beta resources. + + +## Argument Reference + +The following arguments are supported: + + +* `app_id` - + (Required) + The app_id of name of the Firebase iosApp. + + +- - - + + +* `project` - (Optional) The ID of the project in which the resource belongs. + If it is not provided, the provider project is used. + + +## Attributes Reference + +In addition to the arguments listed above, the following computed attributes are exported: + +* `id` - an identifier for the resource with format `{{name}}` + +* `name` - + The fully qualified resource name of the App, for example: + projects/projectId/iosApps/appId + +* `app_id` - + Immutable. The globally unique, Firebase-assigned identifier of the App. + This identifier should be treated as an opaque token, as the data format is not specified. + +* `display_name` - + The user-assigned display name of the App. + +* `bundle_id` - + The canonical bundle ID of the Apple app as it would appear in the Apple AppStore. + +* `app_store_id` - + The automatically generated Apple ID assigned to the Apple app by Apple in the Apple App Store. + +* `team_id` - + The Apple Developer Team ID associated with the App in the App Store.