-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request_reason in provider is not setting values in audit logs #10271
Comments
Looks like provider is sending information in API. See trace bwlow
|
@imrannayer I guess recording the reason into the audit log is handled by the api. From the provider's perspective, it works as designed as you can see here. Can you file an issue against api? Let me know what you think |
I tested this feature using gcloud command and it is working fine. So I am not sure is this is an API issue. Here is how I tested it.
@edwardmedia is it possible if you can create an issue for API team as I am not sure which API it will be. |
@imrannayer I see what you mean. I guess it depends on which service you try to use. It seems not all APIs support it. To verify it, can you run below command to see if that is the same?
|
Got it. Thanks @edwardmedia for checking. Just tested creating secret using Terraform and it is showing request_reason in audit logs. |
@imrannayer yes, I think this feature is case by case. For secrets, yes. But for compute instance and storage. not yet in their APIs. For the provider side, it is already implemented. To request the feature, I guess you need to reach out to the individual api service support. Let me close this issue. You may reopen if you need to continue the investigation. Thank you |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
modular-magician
user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned tohashibot
, a community member has claimed the issue already.Terraform Version
Terraform v1.0.5
on darwin_amd64
Affected Resource(s)
provider "google"
provider "google-beta"
Terraform Configuration Files
Debug Output
Panic Output
Expected Behavior
Audit log is suppose to show value passed to
request_reason
Actual Behavior
Audit log is missing value
reason: somereason
Steps to Reproduce
terraform apply
Important Factoids
References
request_reason
The text was updated successfully, but these errors were encountered: