Promote IAM conditions to GA

[melinath]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

It looks like IAM conditions have been GA for a while: https://cloud.google.com/iam/docs/release-notes#February_28_2020

It would be great to start generating them into the GA provider.

New or Affected Resource(s)

• google_*

• All IAM resources

[SarahFrench]

@BBBmau it looks like this issue might be addressed already in this PR from 2020 : GoogleCloudPlatform/magic-modules#3729

I think the remaining work is to update IAM resources to include conditions, which is now possible due to that PR above. What that would look like is adding iam_conditions_request_type to the YAML for a given resource's IAM resources:

  # If IAM conditions are supported, set this attribute to indicate how the
  # conditions should be passed to the API. Allowed values: :QUERY_PARAM,
  # :REQUEST_BODY, :QUERY_PARAM_NESTED. Note: :QUERY_PARAM_NESTED should
  # only be used if the query param field contains a `.`
  # iam_conditions_request_type: :REQUEST_BODY

(From an IAM section in the contribution guide)

---

I think it's your choice about whether you want to pivot to a different 'promote to GA' task, or to proceed with adding IAM conditions to some IAM resources.

[SarahFrench]

Looking at this again, I see that the PR above was from 2020 but this issue was opened in 2021. @melinath does this issue represent adding iam_conditions_request_type to all the GA IAM resources?

[melinath]

@SarahFrench It's been a while but I think that (at the time) I thought that an IAM resource that had conditions in Beta would not have them included in GA. But I see generated IAM resources in GA with support for conditions so I either misunderstood or this has been resolved in the meantime.

[SarahFrench]

No worries, I just wanted to make sure I wasn't missing something. I'll close this issue, and users can request conditions to be added to GA IAM resources in future GH issues.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.