Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE Autopilot updates in place on every apply with no config changes #11133

Assignees
Labels

Comments

@TomTeece
Copy link

TomTeece commented Feb 18, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.1.6
on darwin_amd64

  • provider registry.terraform.io/hashicorp/google v4.11.0
  • provider registry.terraform.io/hashicorp/null v3.1.0
  • provider registry.terraform.io/hashicorp/random v3.1.0

Affected Resource(s)

google_container_cluster

Terraform Configuration Files

resource "google_container_cluster" "autopilot-cluster" {
  name               = "autopilot-cluster"
  location           = "europe-west2"
  enable_autopilot   = true
  project            = google_project.project.project_id
  initial_node_count = 1
  network            = resource.google_compute_network.default.id
  private_cluster_config {
    enable_private_nodes    = "true"
    enable_private_endpoint = "true"
    master_ipv4_cidr_block  = "<cidr>"
  }
  master_authorized_networks_config {
    cidr_blocks {
      cidr_block   = "<cidr>"
      display_name = "default europe-west2"
    }
  }
}

Debug Output

Panic Output

Expected Behavior

On terraform apply after nothing has changed to terraform config there should be no update to google_container_cluster.autopilot-cluster

Actual Behavior

On every terraform apply the cluster is updated in place . The vertical_pod_autoscaling.enabled = true is set to null on every apply. See the output below.

This does not effect the vertical_pod_autoscaling of the cluster but is not correct. In autopilot Vertical Pod autoscaling is enabled by default so it should be enabled by default when enable_autopilot = true - https://cloud.google.com/kubernetes-engine/docs/how-to/vertical-pod-autoscaling

  # google_container_cluster.autopilot-cluster will be updated in-place
  ~ resource "google_container_cluster" "autopilot-cluster" {
        id                          = "projects/<project-id>/locations/europe-west2/clusters/autopilot-cluster"
        name                        = "autopilot-cluster"
        # (25 unchanged attributes hidden)

      - vertical_pod_autoscaling {
          - enabled = true -> null
        }

        # (17 unchanged blocks hidden)
    }

Steps to Reproduce

  1. terraform apply

Important Factoids

References

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.