Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EvaluationMissingData to google_monitoring_alert_policy #11161

Comments

@alexpls
Copy link

alexpls commented Feb 24, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Add EvaluationMissingData property to google_monitoring_alert_policy resource.

This property can be set using the GCP UI or CLI, but not with Terraform.

Its API documentation can be found here. And on the UI it appears here:

image

New or Affected Resource(s)

*google_monitoring_alert_policy

Potential Terraform Configuration

resource "google_monitoring_alert_policy" "my_alert" {
  # ...

  conditions {
    # ...
    condition_monitoring_query_language {
      # ...
      evaluation_missing_data = "EVALUATION_MISSING_DATA_INACTIVE"
    }
  }
}

References

N/A

@rileykarson rileykarson added this to the Goals milestone Feb 28, 2022
@nnutter
Copy link

nnutter commented Mar 29, 2022

Would adding this feature be something you would accept as a contribution? Looks like the contribution would actually be on https://github.com/GoogleCloudPlatform/magic-modules? If so we could fork that and prepare a PR? Then "modular-magician" would eventually update this repo?

@cubasuarez
Copy link

yes please.

@KaelBaldwin
Copy link

I was working on this with @nnutter and have it mostly done I think if this can be assigned to me. I'll create a PR on https://github.com/GoogleCloudPlatform/magic-modules once it's confirmed I can take this and reference it here. Thanks.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.