Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GKE] Support Reservation Affinity #11597

Closed
wuisawesome opened this issue Apr 27, 2022 · 2 comments
Closed

[GKE] Support Reservation Affinity #11597

wuisawesome opened this issue Apr 27, 2022 · 2 comments

Comments

@wuisawesome
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

This is a feature request to support setting reservation affinity on GKE clusters (via the node_config block of google_container_cluster and google_container_node_pool). This would be consistent with the GCP REST and gRPC APIs.

Reservation affinity for GKE is described in more detail here.

New or Affected Resource(s)

  • google_container_cluster
  • google_container_node_pool

Potential Terraform Configuration

# Consume a specific reseration.
resource "google_container_node_pool" "a_node_pool" {
  name       = "my-node-pool"
  location   = "us-central1"
  cluster    = google_container_cluster.primary.name
  node_count = 1

  node_config {
    machine_type = "e2-medium"
    reservation_affinity {
      consume_reservation_type = "SPECIFIC_RESERVATION"
      key = "googleapis.com/reservation-name"
      values = ["my-reservation-1", "reservation-2"]
    }
  }
}

# Other reservation types with less fields.
resource "google_container_node_pool" "another_node_pool" {
  name       = "my-node-pool"
  location   = "us-central1"
  cluster    = google_container_cluster.primary.name
  node_count = 1

  node_config {
    machine_type = "e2-medium"
    reservation_affinity {
      consume_reservation_type = "ANY_RESERVATION"
    }
  }
}

References

@melinath
Copy link
Collaborator

Resolved by GoogleCloudPlatform/magic-modules#6412

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants