Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification that PubSub topic message retention duration can be up to 31 days #12355

Closed
christianTNG opened this issue Aug 22, 2022 · 2 comments

Comments

@christianTNG
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The argument message_retention_duration for google_pubsub_topic is limited to Cannot be more than 7 days according to its terraform documentation.

However the Google Cloud documentation allows for up to 31 days since a change in December 2021. See Google's blog post for more details.

It would be very helpful to clarify the terraform documentation of google_pubsub_topic by including the latest change concerning the maximal duration.

Affected Resource

  • google_pubsub_topic

References

@c2thorn
Copy link
Collaborator

c2thorn commented Aug 22, 2022

This should be addressed in GoogleCloudPlatform/magic-modules#6430

@c2thorn c2thorn closed this as completed Aug 22, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants