google_compute_per_instance_config/google_compute_region_per_instance_config ignores the most_disruptive_allowed_action argument

[cg547]

Whatever value is set in the most_disruptive_allowed_action argument in the google_compute_per_instance_config/google_compute_region_per_instance_config resources is being overridden by the provider to REPLACE, causing instances to unexpectedly be recreated.

The offending code is most likely this, overriding when the string is not empty:

terraform-provider-google/google/resource_compute_per_instance_config.go

Lines 384 to 388 in f84e342

	mostDisruptiveAction := d.Get("most_disruptive_action_allowed")
	if mostDisruptiveAction != "" {
	mostDisruptiveAction = "REPLACE"
	}
	obj["mostDisruptiveActionAllowed"] = mostDisruptiveAction

terraform-provider-google/google/resource_compute_region_per_instance_config.go

Lines 393 to 397 in f84e342

	mostDisruptiveAction := d.Get("most_disruptive_action_allowed")
	if mostDisruptiveAction != "" {
	mostDisruptiveAction = "REPLACE"
	}
	obj["mostDisruptiveActionAllowed"] = mostDisruptiveAction

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.2.8
on linux_amd64
+ provider registry.terraform.io/hashicorp/dns v3.2.3
+ provider registry.terraform.io/hashicorp/google v4.33.0
+ provider registry.terraform.io/hashicorp/google-beta v4.33.0
+ provider registry.terraform.io/hashicorp/random v3.3.2

Affected Resource(s)

• google_compute_per_instance_config
• google_compute_region_per_instance_config

Terraform Configuration Files

resource "google_compute_per_instance_config" "REDACTED" {
  name                             = "REDACTED"
  instance_group_manager           = google_compute_instance_group_manager.REDACTED.name
  zone                             = "REDACTED"
  minimal_action                   = "NONE"
  most_disruptive_allowed_action   = "NONE"
  remove_instance_state_on_destroy = true

  preserved_state {
    disk {
      device_name = "REDACTED"
      source      = google_compute_disk.REDACTED.id
    }
  }
}

Debug Output

---[ REQUEST ]---------------------------------------
POST /compute/v1/projects/REDACTED/zones/REDACTED/instanceGroupManagers/REDACTED/applyUpdatesToInstances?alt=json HTTP/1.1
Host: compute.googleapis.com
User-Agent: Terraform/1.2.8 (+https://www.terraform.io) Terraform-Plugin-SDK/2.10.1 terraform-provider-google/dev
Content-Length: 132
Content-Type: application/json
Accept-Encoding: gzip

{
 "instances": [
  "zones/REDACTED/instances/REDACTED"
 ],
 "minimalAction": "NONE",
 "mostDisruptiveActionAllowed": "REPLACE"
}

Panic Output

Expected Behavior

The provider calls applyUpdatesToInstances with mostDisruptiveActionAllowed set to "NONE".

Actual Behavior

The provider calls applyUpdatesToInstances with mostDisruptiveActionAllowed set to "REPLACE".

Steps to Reproduce

1. terraform apply

Important Factoids

References

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.