Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New major version] Make DELETE the default destroy behavior for google_firebase_web_app #12810

Closed
rainshen49 opened this issue Oct 17, 2022 · 2 comments

Comments

@rainshen49
Copy link
Contributor

rainshen49 commented Oct 17, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

After GoogleCloudPlatform/magic-modules#6652, backward compatibility requires terraform destroy to skip deleting the Firebase Web App by default, unless deletion_policy="DELETE" is specified. The new and more intuitive default behavior would be deletion_policy="DELETE", which actually deletes the resource.

New or Affected Resource(s)

  • google_firebase_web_app

References

GoogleCloudPlatform/magic-modules#6652

b/277381663

@c2thorn
Copy link
Collaborator

c2thorn commented Sep 11, 2023

closed with GoogleCloudPlatform/magic-modules#8458

This will release with v5.0.0. Check #15582 for more details on the major release.

Closing this issue for tracking purposes.

@c2thorn c2thorn closed this as completed Sep 11, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants