Add TCP TIME_WAIT to google_compute_router_nat

[sh4sh]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Is it possible to add configurable TCP TIME_WAIT to Cloud NAT? This request has previously been tracked in #10666 and its associated PRs, but it was reverted due to a conflict. As far as I can tell it did not get implemented.

#10666 (comment) by @black-snow explains well:

I just stumbled over this. Why do we have all the options (https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_router_nat#tcp_established_idle_timeout_sec) except for the TCP wait time? :D

Should be this: https://cloud.google.com/sdk/gcloud/reference/compute/routers/nats/create?hl=de#--tcp-time-wait-timeout

The PR should look a lot like GoogleCloudPlatform/magic-modules@09bc35c, I guess. But I have zip go knowledge :/

New or Affected Resource(s)

• google_XXXXX

Potential Terraform Configuration

resource "google_compute_router_nat" "foobar" {
  name                               = "%s"
  router                             = google_compute_router.foobar.name
  region                             = google_compute_router.foobar.region
  nat_ip_allocate_option             = "AUTO_ONLY"
  source_subnetwork_ip_ranges_to_nat = "ALL_SUBNETWORKS_ALL_IP_RANGES"
  tcp_time_wait_timeout_sec          = "%d"
}

References

• Original issue: Cloud NAT Rules and Configurable TCP Time Wait #10666
• PR: Cloud NAT Rules and Configurable TCP Time Wait GoogleCloudPlatform/magic-modules#6221
• Revert: Revert "Cloud NAT Rules and Configurable TCP Time Wait" GoogleCloudPlatform/magic-modules#6343

[yudoufu]

I'll take this issue.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.