Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null send_after values fail to parse when batching is set #14250

Comments

@rileykarson
Copy link
Collaborator

rileykarson commented Apr 7, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

TPG(B) 4.60.2 is the first affected version (although the issue is certainly present in 4.60.0 / 4.60.1 as well)

Affected Resource(s)

  • provider

Terraform Configuration Files

provider "google" {
  version = "~> 4.60.2"
  batching {
    send_after = null # omitting this works too
    enable_batching = false
  }
}

# any resource using the provider. If no resource is present the provider is never initialized.
resource "google_bigquery_dataset" "dataset_other" {
  dataset_id               = "foobar"
  project                     = "my-primary-project"
  location                    = "EU"
}

Debug Output

Panic Output

Expected Behavior

The default of 10s should be set

Actual Behavior

Error: unable to parse duration from 'send_after' value ""

Steps to Reproduce

  1. terraform apply

Important Factoids

Note that this is actually the SDK error message, not the framework one. I think we're failing to fill in the default value when send_after is unset but batching is.

References

  • b/277254338
@rileykarson rileykarson added the bug label Apr 7, 2023
@rileykarson
Copy link
Collaborator Author

Note: a configuration like the following works, as a workaround:

provider "google" {
  version = "~> 4.60.2"
  batching {
    send_after = "10s"
    enable_batching = false
  }
}

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.