-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No validation on role_id using google_organization_iam_custom_role #14435
No validation on role_id using google_organization_iam_custom_role #14435
Comments
Below validation is supposed to be called https://github.com/hashicorp/terraform-provider-google/blob/main/google/validation.go#L34 |
Additional hint, in the docs of google_project_iam_custom_role (https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/google_project_iam_custom_role#role_id) there is a hint that hyphens are not allowed. Maybe this should be added to the docs of google_organization_iam_custom_role as well. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
modular-magician
user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned tohashibot
, a community member has claimed the issue already.Terraform Version
Terraform v1.4.5
Affected Resource(s)
Terraform Configuration Files
Debug Output
https://gist.github.com/MacMullen/033953f4468244b747363c2233cff2dd
Panic Output
Expected Behavior
When given an invalid role_id (in this case due to the use of hyphens), a validation from the resource should trigger an error.
Actual Behavior
No validation error is triggered, causing the API request to fail with a 400 status code, and the explanation of said error not mentioning that the invalid role_id is causing the issue.
Steps to Reproduce
terraform apply
Important Factoids
References
Best wishes,
A fellow Googler.
The text was updated successfully, but these errors were encountered: