Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Cloud Memorystore Resources #1467

Closed
dimitropoulos opened this issue May 10, 2018 · 8 comments
Closed

Feature Request: Cloud Memorystore Resources #1467

dimitropoulos opened this issue May 10, 2018 · 8 comments
Assignees

Comments

@dimitropoulos
Copy link

Now in Beta: Cloud Memorystore fills an important void in the GCP landscape. It would be fantastic to have support for it.

References

@mrparkers
Copy link
Contributor

mrparkers commented May 11, 2018

If nobody has signed up to take this on, I'll volunteer to work on this over the weekend.

@pdecat
Copy link
Contributor

pdecat commented May 11, 2018

@mrparkers I'm not sure its worth to implement it by hand given new resources are now generated by the @modular-magician : https://github.com/modular-magician/terraform-provider-google / https://github.com/GoogleCloudPlatform/magic-modules

@mrparkers
Copy link
Contributor

@pdecat Cool, I didn't know that existed. How long does it usually take for resources to be implemented automatically? I'd like for this resource to exist before the next release of this provider, so I really don't mind doing this manually if it means achieving that.

I was also looking for something to do this weekend so I may just do it anyways 😄 if nothing else, it's an opportunity to help me learn Go

@danawillow
Copy link
Contributor

@mrparkers it depends on the API in question and whether magic modules has support for all the features (for lack of a better term) of that API. I was playing around with this the other day and found one that needs to be added: https://github.com/GoogleCloudPlatform/magic-modules/issues/182. I was planning on doing this early next week, and I think that'll be the only thing that blocks this, so if you could hold off that would be great (since it's easier if we generate things from the onset than to generate something that's already been done by hand). I'll let you know if I change my mind.

If you're looking for things to work on though, there are plenty of other open issues 😉

@danawillow danawillow self-assigned this May 11, 2018
@mrparkers
Copy link
Contributor

@danawillow sounds good, I can look for something else.

This is a bit off-topic, but does this repository have a concept of tagging "good first issues"? Although I have contributed before, I'm still very new to Go and I was looking for ways to help with my learning experience. Usually new resources are pretty easy, which is why I wanted to work on this one.

@paddycarver
Copy link
Contributor

So we've got the good first issue and help wanted labels, which are made for tracking things we believe to be straightforward enough that someone could tackle them as a first contribution. We haven't gotten great at using them (or at least I haven't), so they may be of limited use. There's also easy, which is going to go away, because I dislike the implications of that one, but historically that has been how we tracked things.

@danawillow
Copy link
Contributor

Added in #1485.

@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants