-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent behaviour between SDK and plugin framework provider config code when handling region self-links #15714
Inconsistent behaviour between SDK and plugin framework provider config code when handling region self-links #15714
Comments
@SarahFrench @BBBmau does GoogleCloudPlatform/magic-modules#8587 also fix this? |
No it doesn't - that PR only touches helper functions used for finding location/region/zone values for resources and data sources. This issue is super similar but is specific to the provider config code. I can put in a quick PR to fix this today, but this issue is more of a code-inconsistency issue (i.e. doesn't need to be done for 5.0.0) as I don't think this defect is user facing:
|
That's fair, then I will remove it from the 5.0.0 milestone just for tracking. |
👍 Thanks, I'd overlooked that I'd added it to that milestone! I'll make a PR into main and it can be released soon after 5.0.0 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
modular-magician
user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned tohashibot
, a community member has claimed the issue already.Terraform Version
N/A
Affected Resource(s)
Terraform Configuration Files
N/A
Debug Output
N/A
Panic Output
N/A
Expected Behavior
The SDK provider config code transforms the region value from a self link to a region name: link to unit test showing this
We'd expect the plugin framework version of that logic to behave the same way
Actual Behavior
The plugin framework version of that logic leaves the region value as a self link : link to failing unit test
I haven't checked, but I think this doesn't impact users because the
GetRegion
functions used in the provider can accept a self link value and change it into a region name.Steps to Reproduce
Uncomment and run the affected unit test using the code that's currently on main branch - the test will fail
Important Factoids
The SDK and PF provider config code follow the same pattern of having one struct/variable that contains the provider configuration data in a SDK-y or Plugin Framework-y way, and that data is used to populate a struct that's specific to the Google provider. The SDK code performs this truncation of the value when copying the region data to that second struct, but the Plugin Framework code doesn't.
References
The text was updated successfully, but these errors were encountered: