Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memcached 1.6 not supported in Terraform #16191

Closed
Sourc opened this issue Oct 10, 2023 · 6 comments
Closed

Memcached 1.6 not supported in Terraform #16191

Sourc opened this issue Oct 10, 2023 · 6 comments

Comments

@Sourc
Copy link

Sourc commented Oct 10, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

All, tested with 5.1.0.

Affected Resource(s)

google_memcache_instance

Expected Behavior

Specifying the property memcache_version = "MEMCACHE_1_6" should work since it's possible to upgrade instances from 1.5 to 1.6 (even though the GUI does not yet support creating instances with version 1.6, at the time of writing).

Actual Behavior

Terraform fails to plan, expected memcache_version to be one of [MEMCACHE_1_5 ], got MEMCACHE_1_6

b/305197643

@Sourc Sourc added the bug label Oct 10, 2023
@github-actions github-actions bot added forward/review In review; remove label to forward service/memcache labels Oct 10, 2023
@edwardmedia
Copy link
Contributor

@Sourc Trying to understand if this issue is at the provider level or the API. Can you share the config and debug log?

@edwardmedia edwardmedia added waiting-response and removed forward/review In review; remove label to forward labels Oct 10, 2023
@Sourc
Copy link
Author

Sourc commented Oct 10, 2023

I don't know if the APIs have been updated behind the scenes to fully support version 1.6 yet, but right now we're not getting past the validation here (I assume, without looking through the whole codebase) https://github.com/hashicorp/terraform-provider-google/blob/main/google/services/memcache/resource_memcache_instance.go#L240 (magic modules)

@gaurav172
Copy link

The issue is at provider level. APIs have been updated to support 1.6.15 in create instance as well as upgrade instance call https://cloud.google.com/memorystore/docs/memcached/create-instance-gcloud#creating_a_memcached_instance

@gaurav172
Copy link

@trodge can this issue be closed now that the PR is merged ?

@melinath
Copy link
Collaborator

This is resolved now that the PR is merged - thanks!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants