-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unique_writer_identity default value change on google_logging_project_sink does not trigger a change on dependant usages of writer_identity attribute #16622
unique_writer_identity default value change on google_logging_project_sink does not trigger a change on dependant usages of writer_identity attribute #16622
Comments
For the record, I tried to manually taint the
|
I also tested to explicitly define |
@ferrastas your case is related to the known breaking change in v5.0.0.
I guess there are not many options we have about this. Do you agree? |
@edwardmedia I'm aware of this BC and I already explained about it in the "expected behaviour" section. What I'm reporting is that I expect that if I set |
@ferrastas I do see what you meant now. This issue is tricky as the issue is between There is little options do we have to fix the issue. Likely it requires a solution from Terraform core. Adding the label of upstream-terraform |
@edwardmedia we can probably resolve this with a CustomizeDiff, actually. Is that something you'd be able to test out yourself? I'm looking into a different issue atm. While we're there we could also call
|
@rileykarson +1, I just faced this other issue you mentioned when playing around with the flag 😭 . |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
modular-magician
user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned tohashibot
, a community member has claimed the issue already.Terraform Version
1.6.3
Affected Resource(s)
Terraform Configuration Files
Debug Output
Panic Output
Expected Behavior
After upgrading the provider to 5.X and according to the documentation, the default value for
unique_writer_identity
changes fromfalse
totrue
, this implies a change on the attributewriter_identity
fromcloud-logs@system.gserviceaccount.com
toservice-<PROJECT_NUMBER>@gcp-sa-logging.iam.gserviceaccount.com
.And I expect that all usages of that attribute will be marked for recreation/modification.
Actual Behavior
The value for
writer_identity
is silently changed, dependant usages are not triggered and we got a permission issue on our end.Kicking a new terraform plan detects the changes on that attribute and dependent resources are correctly marked for modification
Steps to Reproduce
4.x
provider version available5.x
(IAM resources will not be present on the plan)
Important Factoids
References
The text was updated successfully, but these errors were encountered: