Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s): TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update #17535

Closed
c2thorn opened this issue Mar 8, 2024 · 5 comments
Closed

Comments

@c2thorn
Copy link
Collaborator

c2thorn commented Mar 8, 2024

Impacted tests

b/329686752

  • TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Affected Resource(s)

  • google_kms_ekm_connection

Failure rates

  • 100% since 2024-03-07

Message(s)

 Error: Request `Create IAM Members roles/servicedirectory.viewer serviceAccount:service-653407317329@gcp-sa-ekms.iam.gserviceaccount.com for project "650527956789"` returned error: Batch request and retried single request "Create IAM Members roles/servicedirectory.viewer serviceAccount:service-653407317329@gcp-sa-ekms.iam.gserviceaccount.com for project \"650527956789\"" both failed. Final error: Error applying IAM policy for project "650527956789": Error setting IAM policy for project "650527956789": googleapi: Error 400: Service account service-653407317329@gcp-sa-ekms.iam.gserviceaccount.com does not exist., badRequest

Similar error in GA tests. This test required external set up in the service team's environment (secrets, etc). Test passes in the VCR project, but looks like it was not set up correctly in the nightly projects.

Nightly build test history

b/330375061

@github-actions github-actions bot added forward/review In review; remove label to forward service/cloudkms labels Mar 8, 2024
@roaks3 roaks3 added the test-failure-100 100% fail rate label Mar 14, 2024
@rileykarson rileykarson added this to the Goals milestone Mar 18, 2024
@roaks3 roaks3 added forward/linked and removed forward/review In review; remove label to forward labels Mar 19, 2024
@tdbhacks
Copy link

tdbhacks commented Apr 5, 2024

I believe this is now fixed :)

@c2thorn
Copy link
Collaborator Author

c2thorn commented Apr 5, 2024

Checked again, they started failing again :(

@tdbhacks
Copy link

tdbhacks commented Apr 8, 2024

Hmm, my guess is that this is what's causing the permissions to be reset: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/kms/resource_kms_ekm_connection_test.go#L63-L72

I might be wrong though, will double-check with Risham.

@shuyama1
Copy link
Collaborator

Looks like this is resolved now. Closing the ticket

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants