Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Deploy CustomTargetType remote Skaffold config support with Cloud Build repositories #17935

Comments

@katiexzhang
Copy link

katiexzhang commented Apr 23, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

When defining custom targets for Cloud Deploy, Terraform should support using Cloud Build V2 Repositories as remote Skaffold configs.

New or Affected Resource(s)

  • google_clouddeploy_custom_target_type

Potential Terraform Configuration

resource "google_clouddeploy_custom_target_type" "custom-target-type" {
    location = "us-central1"
    name = "tf-test-my-custom-target-type%{random_suffix}"
    description = "My custom target type"
    custom_actions {
      render_action = "renderAction"
      deploy_action = "deployAction"
      include_skaffold_modules {
        configs = ["my-config"]
        google_cloud_build_repo {
          repository = "projects/777/locations/us-central1/connections/git/repositories/repo"
          path = "configs/skaffold.yaml"
          ref = "main"
        }
      }
    }
}

References

https://cloud.google.com/deploy/docs/api/reference/rest/v1/projects.locations.customTargetTypes#skaffoldgcbreposource

b/337873627

@rileykarson
Copy link
Collaborator

Assigning based on linked PR

Copy link

github-actions bot commented Jun 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.