Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why adding new tags and labels destroys node pool and create new one #2532

Closed
rohitvyavahare opened this issue Nov 27, 2018 · 3 comments
Closed
Labels

Comments

@rohitvyavahare
Copy link

rohitvyavahare commented Nov 27, 2018


Adding new tags to the existing node pools destroys node pool and create a new one. I can add tags to the existing node-pool from the console.

Here is the output :

-/+ destroy and then create replacement

Terraform will perform the following actions:

-/+ module.node_pool_es_client.google_container_node_pool.node_pool_autoscale (new resource required)
      id:                                                       "us-west1/lab/es-client" => <computed> (forces new resource)
      autoscaling.#:                                            "1" => "1"
      autoscaling.0.max_node_count:                             "1" => "1"
      autoscaling.0.min_node_count:                             "1" => "1"
      cluster:                                                  "lab" => "lab"
      initial_node_count:                                       "1" => "1"
      instance_group_urls.#:                                    "3" => <computed>
      management.#:                                             "1" => "1"
      management.0.auto_repair:                                 "false" => "false"
      management.0.auto_upgrade:                                "false" => "false"
      max_pods_per_node:                                        "110" => <computed>
      name:                                                     "es-client" => "es-client"
      name_prefix:                                              "" => <computed>
      node_config.#:                                            "1" => "1"
      node_config.0.disk_size_gb:                               "100" => "100"
      node_config.0.disk_type:                                  "pd-standard" => "pd-standard"
      node_config.0.image_type:                                 "COS" => "COS"
      node_config.0.labels.%:                                   "1" => "1"
      node_config.0.labels.node.signafx.com/es_client: "true" => "true"
      node_config.0.local_ssd_count:                            "0" => "0"
      node_config.0.machine_type:                               "n1-standard-4" => "n1-standard-4"
      node_config.0.oauth_scopes.#:                             "4" => "4"
      node_config.0.oauth_scopes.1277378754:                    "https://www.googleapis.com/auth/monitoring" => "https://www.googleapis.com/auth/monitoring"
      node_config.0.oauth_scopes.1632638332:                    "https://www.googleapis.com/auth/devstorage.read_only" => "https://www.googleapis.com/auth/devstorage.read_only"
      node_config.0.oauth_scopes.172152165:                     "https://www.googleapis.com/auth/logging.write" => "https://www.googleapis.com/auth/logging.write"
      node_config.0.oauth_scopes.299962681:                     "https://www.googleapis.com/auth/compute" => "https://www.googleapis.com/auth/compute"
      node_config.0.preemptible:                                "false" => "false"
      node_config.0.service_account:                            "default" => <computed>
      node_config.0.tags.#:                                     "2" => "3" (forces new resource)
      node_config.0.tags.0:                                     "client" => "client"
      node_config.0.tags.1:                                     "lab" => "test" (forces new resource)
      node_config.0.tags.2:                                     "" => "lab" (forces new resource)
      node_count:                                               "1" => <computed>
      project:                                                  "lab-env-139" => "lab-env-139"
      region:                                                   "us-west1" => "us-west1"
      version:                                                  "1.11.2-gke.18" => <computed>
      zone:                                                     "" => <computed>


Plan: 1 to add, 0 to change, 1 to destroy.

same with the labels.
Is this a bug or supposed to happen?

@nat-henderson
Copy link
Contributor

Tags and labels are both ForceNew, yep. I'll check the API to see if that's mandatory or if we can fix that with some effort.

@nat-henderson
Copy link
Contributor

Yep, in the API only nodeVersion and imageType are updatable. WAI - marking as upstream and closing.

@ghost
Copy link

ghost commented Dec 28, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants