Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_container_cluster does not import remove_default_node_pool correctly #3064

Closed
matti opened this issue Feb 15, 2019 · 4 comments · Fixed by GoogleCloudPlatform/magic-modules#1434
Labels

Comments

@matti
Copy link

matti commented Feb 15, 2019

after importing a:

resource "google_container_cluster" "cluster" {
  ...
  remove_default_node_pool = true
}

I get this in plan:

  ~ google_container_cluster.cluster
      remove_default_node_pool: "" => "true"

which fails because the default-pool has already been removed

@matti
Copy link
Author

matti commented Feb 15, 2019

added

  lifecycle {
    ignore_changes = "remove_default_node_pool"
  }

as a workaround

@emilymye
Copy link
Contributor

Interesting - I'm not sure what the best thing to do is here for setting this value on import. Should we attempt to set it based on the presence of nodePools/default-pool? Thoughts @rileykarson?

@rileykarson
Copy link
Collaborator

That seems sensible to me, we could set it to false if GET succeeds and false otherwise; that way, the existing update logic we have that removes the default node pool when you go from false -> true will remove it on the next apply.

@ghost
Copy link

ghost commented Mar 31, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants