Add "use-serving-port" to health-checks

[arnecls]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

For easier use of e.g. network endpoint groups, health checks should support the "--use-serving-port" flag, see [1].

This is especially interesting for network endpoint groups as they can be created via a kubernetes resource which makes the port and/or name not easily available as a terraform resource.

New or Affected Resource(s)

• google_compute_health_check
• google_compute_http_health_check
• google_compute_https_health_check

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

resource "google_compute_health_check" "internal-health-check" {
 name = "internal-service-health-check"

 timeout_sec        = 1
 check_interval_sec = 1

 tcp_health_check {
   use-serving-port = "true"
 }
}

References

• [1] https://cloud.google.com/load-balancing/docs/health-check-concepts#category_and_port_specification
• [2] Add support for network endpoint groups #2263

[emilymye]

Note for self/anyone attempting this: Involves adding a boolean field useServingPort that sets field portSpecification (currently beta) on resource. We want to create this helper field like gcloud did as different values of portSpecification require different fields on resource:

• USE_SERVING_PORT conflicts with port/portName
• USE_FIXED_PORT requires port but providing port alone (i.e. no portSpecification) will do the same thing
• USE_NAMED_PORT requires portName but providing portName alone (i.e. no portSpecification)
  will do the same thing

[megan07]

Thanks @arnecls for opening this issue. It's been closed with #4001 and will be released shortly.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!