Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GKE Workload Identity #3790

Closed
aaron-trout opened this issue Jun 5, 2019 · 4 comments
Closed

Support for GKE Workload Identity #3790

aaron-trout opened this issue Jun 5, 2019 · 4 comments
Labels
enhancement forward/review In review; remove label to forward service/container

Comments

@aaron-trout
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Add support for GKE Workload Identity. This would involve a new field/configuration block on google_container_cluster to enable the workload identity feature, as well as updating the list of allowed values in the workload_metadata_config block which is part of node_config.

New or Affected Resource(s)

  • google_container_cluster
  • google_container_node_pool

Potential Terraform Configuration

resource "google_container_cluster" "my-cluster" {
  ...
  enable_workload_identity = "true"
  ...
}

resource "google_container_node_pool" "my-node-pool" {
  ...
  node_config{
    workload_metadata_config {
      node_metadata = "GKE_METADATA_SERVER"
    }
  }
  ...

References

https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity

  • #0000
@jeremyje
Copy link
Contributor

jeremyje commented Jun 5, 2019

I'm looking to add this.

@rileykarson
Copy link
Collaborator

Closed with GoogleCloudPlatform/magic-modules#1891

@aaron-trout
Copy link
Author

@jeremyje big thanks for the quick work on this! Looking forward to the 2.8.1 release of the google provider :D

@ghost
Copy link

ghost commented Jul 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 8, 2019
@github-actions github-actions bot added service/container forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement forward/review In review; remove label to forward service/container
Projects
None yet
Development

No branches or pull requests

4 participants