Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for L7 ILB #4190

Closed
JasperWoo opened this issue Aug 8, 2019 · 6 comments
Closed

Add support for L7 ILB #4190

JasperWoo opened this issue Aug 8, 2019 · 6 comments

Comments

@JasperWoo
Copy link

JasperWoo commented Aug 8, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

terraform -v
Terraform v0.12.6

  • provider.google v2.12.0
  • provider.google-beta v2.12.0

Affected Resource(s)

  • google_compute_health_check, google_compute_forwarding_rule, etc

Terraform Configuration Files

resource "google_compute_health_check" "default" {
  provider = "google-beta"
  name         = "packer-service-health-check"
  region                   = "us-central1"

  http_health_check {
      port_specification = "USE_SERVING_PORT"
  }
}

Debug Output

https://gist.github.com/JasperWoo/c945a6856e0148e0744c4bd826fa3ca9

Panic Output

None

Expected Behavior

Import successfully

Actual Behavior

Import fails with id not found; however gcloud beta compute describe gives correct data, proving the resource exists. (See gist).

Steps to Reproduce

  1. Create google_compute_health_check using gcloud beta compute
  2. terraform import -provider=google-beta <name of the health_check resource>

Important Factoids

None

References

  1. https://www.terraform.io/docs/providers/google/r/compute_health_check.html
  2. https://cloud.google.com/load-balancing/docs/l7-internal/set-up-gce-vms
  • #0000
@ghost ghost added the bug label Aug 8, 2019
@rileykarson rileykarson self-assigned this Aug 9, 2019
@rileykarson
Copy link
Collaborator

This is a regional variant of the GCP health check used in L7 ILB, and support hasn't been added to the Google provider yet. I'm marking this as an enhancement request and re-titling it.

@rileykarson rileykarson removed their assignment Aug 9, 2019
@rileykarson rileykarson changed the title Cannot import resource created using google-beta Add support for L7 ILB Aug 9, 2019
@ghost ghost added the bug label Aug 9, 2019
@rileykarson
Copy link
Collaborator

@tysen: Assigning since I think you're working on these. If there's another issue can you dedupe to there?/ I'm wrong, feel free to correct the assignment.

@tysen
Copy link

tysen commented Aug 16, 2019

I am indeed working on this 👍

@morgante
Copy link

@tysen Any updates here?

@tysen
Copy link

tysen commented Sep 25, 2019

Just merged GoogleCloudPlatform/magic-modules#2363 but still need to update RegionUrlMap with the many new fields added for L7 ILB.

@paddycarver paddycarver added this to the Near-Term Goals milestone Dec 6, 2019
@danawillow danawillow modified the milestones: Near-Term Goals, Sprint 1 Dec 16, 2019
@tysen tysen closed this as completed Dec 16, 2019
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants