Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove google_container_cluster.cluster_ipv4_cidr #4203

Closed
rileykarson opened this issue Aug 9, 2019 · 3 comments
Closed

Remove google_container_cluster.cluster_ipv4_cidr #4203

rileykarson opened this issue Aug 9, 2019 · 3 comments

Comments

@rileykarson
Copy link
Collaborator

I believe it's superseded by https://www.terraform.io/docs/providers/google/r/container_cluster.html#cluster_ipv4_cidr_block.

@rileykarson
Copy link
Collaborator Author

Hmm- looks like the fields are distinct. The top-level field applies when it's not a VPC-native cluster, and the nested field when the cluster is VPC-native.

The problem is, defining an ip_allocation_policy block at all makes the top-level field no longer work. So if the block is defined and you try to define a pod cidr, neither one will work. I'm not sure there's a remediation.

@rileykarson rileykarson self-assigned this Aug 9, 2019
@rileykarson rileykarson changed the title Remove google_container_cluster. cluster_ipv4_cidr Remove google_container_cluster.cluster_ipv4_cidr Aug 13, 2019
@danawillow danawillow added this to the 3.0.0 milestone Sep 12, 2019
@rileykarson
Copy link
Collaborator Author

rileykarson commented Oct 8, 2019

Closing in favour of #4638 which prevents specifying this in ambiguous ways.

@ghost
Copy link

ghost commented Nov 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants