Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID fields missing from compute_vpn and vpn_gateway resources #4322

Closed
mogthesprog opened this issue Aug 22, 2019 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#2273
Assignees
Labels

Comments

@mogthesprog
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The below resources are both missing their ID fields. These fields are really useful for creating log-based-metrics that fire when the vpn tunnels fail for a number of reasons (phase 2 fails, no valid proposal, etc.).

The fields are called id and are strings, and can be found here:

New or Affected Resource(s)

  • google_compute_vpn_tunnel
  • google_compute_vpn_gateway

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

In this case, two attributes called gateway_id and tunnel_id on each of the resources makes sense I think, and it is returned in the API response.

References

@ghost ghost added the enhancement label Aug 22, 2019
@mogthesprog mogthesprog changed the title ID fields missing from compute_vpn and vpn_gateway resources ID fields missing from compute_vpn and vpn_gateway resources Aug 22, 2019
@megan07 megan07 self-assigned this Aug 29, 2019
@ghost
Copy link

ghost commented Sep 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 30, 2019
@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-vpn labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants