Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict forwarding rule IP Address to prevent permadiff #4461

Closed
emilymye opened this issue Sep 16, 2019 · 1 comment
Closed

Restrict forwarding rule IP Address to prevent permadiff #4461

emilymye opened this issue Sep 16, 2019 · 1 comment
Assignees
Milestone

Comments

@emilymye
Copy link
Contributor

Community Note

Filing issue for tracking

IP Address traditionally supports literal IP address (127.0.0.1), self-link, or various other ways but returns from API as the literal. We can't diff suppress since we don't actually know what self-link corresponds to what address without doing a request, so we should make it so this field only allows the standard IP address. Alternatively, we could do a GET to get the address, but I'd rather not add additional unexpected API calls like that if we don't have to.

Affected Resource(s)

  • google_compute_forwarding_rule
  • google_compute_global_forwarding_rule

References:

Previous PR that was marked for 3.0.0: GoogleCloudPlatform/magic-modules#2080

@emilymye emilymye added this to the 3.0.0 milestone Sep 16, 2019
@ghost ghost added the bug label Sep 16, 2019
@emilymye emilymye self-assigned this Sep 16, 2019
@chrisst chrisst assigned chrisst and unassigned emilymye Nov 6, 2019
@chrisst chrisst closed this as completed Nov 8, 2019
@ghost
Copy link

ghost commented Dec 9, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 9, 2019
@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-l7-load-balancer labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants