Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Placement Policy support #5565

Comments

@danawillow
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

https://cloud.google.com/compute/docs/reference/rest/beta/resourcePolicies/insert (groupPlacementPolicy)
Plus the ability to attach it to an instance and instanceTemplate

New or Affected Resource(s)

  • google_compute_resource_policy
  • google_compute_instance
  • google_compute_instance_template

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

  • b/144708037
@ghost ghost added the enhancement label Feb 1, 2020
@danawillow danawillow added this to the Sprint 6 milestone Feb 3, 2020
@slevenick slevenick self-assigned this Feb 7, 2020
@slevenick
Copy link
Collaborator

Postponing work until update functionality becomes available on compute instance, and resource policies are preserved on instance templates (currently you can POST resource policies but they are never returned)

@slevenick
Copy link
Collaborator

Implementing via GoogleCloudPlatform/magic-modules#3217 that adds support for google_compute_instance and adds placement_policy on google_compute_resource_policy. Will add support for templates and updating instance when it becomes available

@raddaoui
Copy link

raddaoui commented Mar 9, 2020

Thanks @slevenick for this patch.
can we reopen this until we add support for google_compute_instance_template as per the description or maybe track it in another issue.

@slevenick
Copy link
Collaborator

Opened #5863 to track this for instance templates

@ghost
Copy link

ghost commented Apr 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.