Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access_context_manager_access_policy requireScreenLock is broken #6195

Assignees
Labels

Comments

@jmymy
Copy link

jmymy commented Apr 24, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.12.24

  • provider.google v3.18.0

Affected Resource(s)

  • google_access_context_manager_access_level

Terraform Configuration Files

resource "google_access_context_manager_access_level" "bug" {
  parent = "accessPolicies/${google_access_context_manager_access_policy.example.name}"
  name   = "accessPolicies/${google_access_context_manager_access_policy.example.name}/accessLevels/bug"
  title  = "bug"
  basic {
    conditions {
      device_policy {
        require_screen_lock         = true
        allowed_encryption_statuses = ["ENCRYPTED"]
        os_constraints {
          os_type         = "DESKTOP_MAC"
          minimum_version = "10.15.0"
        }
      }
    }
  }
}

Debug Output

Panic Output

Expected Behavior

it creates a policy with requireScreenLock

Actual Behavior

Error: Error updating AccessLevel "accessPolicies/XXXXX/accessLevels/bug": googleapi: Error 400: Invalid JSON payload received. Unknown name "requireScreenLock" at 'access_level.basic.conditions[0].device_policy': Cannot find field.

Steps to Reproduce

  1. terraform apply

Important Factoids

References

https://cloud.google.com/access-context-manager/docs/reference/rest/v1beta/accessPolicies.accessLevels?hl=en#DevicePolicy
https://github.com/terraform-providers/terraform-provider-google/blob/master/google/resource_access_context_manager_access_level.go#L544

  • #0000

It appears there is a camelcase issue here. Getting requireScreenLock instead of the google api field requireScreenlock (google is inconsistent in this one case)

@ghost ghost added the bug label Apr 24, 2020
@edwardmedia edwardmedia self-assigned this Apr 24, 2020
@edwardmedia
Copy link
Contributor

edwardmedia commented Apr 24, 2020

I can repro this issue. Above code works fine if I set require_screen_lock =false. But once I set it to require_screen_lock=true, it generates above error.

@ghost
Copy link

ghost commented May 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.