Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BackendConfig #6504

Closed
larsenqec opened this issue Jun 1, 2020 · 3 comments
Closed

Add support for BackendConfig #6504

larsenqec opened this issue Jun 1, 2020 · 3 comments
Assignees

Comments

@larsenqec
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

We currently use a BackendConfig object to be able to control timeouts on kubernetes services. By creating a named BackendConfig object, services can reference that name in their annotations thereby overriding the (short) default timeouts. Services that handle large file uploads or other long running processes need longer timeouts. Timeouts are my use-case, but there are other features in BackendConfig.

New or Affected Resource(s)

  • google_compute_backend_config

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

resource google_compute_backend_config my_backend_config {
  metadata {
    name = "my_backend_timeout"
  }
  timeout_sec = 600
  iap = ...
  cdn = ...
  securityPolicy = ...
  connectionDraining = ...
  sessionAffinity = ...
  customRequestHeaders = ...
  logging = ...
}

References

@rileykarson
Copy link
Collaborator

Hey @larsenqec!

I'm not sure that this resource is something that should be managed using this provider. While it's true that it's somewhat of a GCP resource, given that it's a GKE-published Kubernetes custom resource that creates a backend service, it isn't a resource that's [directly] created through the GCP APIs.

The google (and google-beta) providers are aware of how to authenticate with GCP's REST APIs, but to support this (and other K8S custom resources) we'd need to also allow configuring Kubernetes authentication / pointing the provider at a K8S cluster. Definitely possible, but undesirable- one authentication method / api service to provider is the general pattern providers follow.

I think that the best way to configure that custom resource today would be the new kubernetes-alpha provider using the kubernetes_manifest resource, which was created to handle managing custom resources. Otherwise, the helm provider is another alternative.

Has it been your experience that there are a handful of GCP-specific custom resources you want to be able to configure, or is this the only one? One (long-term) possibility would be if we explored a provider with first-class resources for GCP CRs to be used alongside the kubernetes provider.

@larsenqec
Copy link
Author

Yes, I suppose it is complicated if it's not exposed through the Google REST API. I will look at the kubernetes_manifest resource. Thank you.

@ghost ghost removed the waiting-response label Jun 10, 2020
@ghost
Copy link

ghost commented Jul 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants