-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Beta provider] Add support for new kubelet and sysctl option groups for GKE nodes #6773
[Beta provider] Add support for new kubelet and sysctl option groups for GKE nodes #6773
Comments
Hey - happy to work on this one. I can submit an PR in the next few (2-3) days. |
@gplasky LinuxNodeConfig takes a Sysctls map[string]string where the keys are the kernel configs in the original format. Your proposed configuration replaces dots with dashes. Any thoughts on that? I started to do something like:
But it feels a bit forced... Not sure if there's precedence in other places in the providers where we avoid having dots in the attribute names. I'd like some feedback on this before I get too far with unit tests and all that good stuff. |
I have no strong preference on the format, and in fact waffled a bit when deciding which formatting to use in my example. I'm not actually sure if TF supports dot-based naming but I'm definitely in favor of going down that route if so. That said, I believe only underscores and dashes are supported: https://www.terraform.io/docs/configuration/syntax.html#identifiers If that's the case I think that leaves us with either all underscores (loses the distinction of the separate sections e.g. net.foo.bar) or use dashes to differentiate as in the above. No strong opinion on either. Edit: After a quick scan through the codebase, the all |
Sounds good. If we use only |
Opened a PR, it's still WIP (needs more tests and one of the acceptance tests doesn't pass right now) but any early feedback is appreaciated. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Community Note
Description
Node Configs for controlling select Kubelet and sysctl values (NodeKubeletConfig and LinuxNodeConfig, respectively) is now available in the beta Kubernetes Engine API as a part of the NodeConfig object.
New or Affected Resource(s)
Affected:
Potential Terraform Configuration
References
https://cloud.google.com/sdk/gcloud/reference/beta/container/clusters/create#--system-config-from-file
https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/NodeConfig#LinuxNodeConfig
https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/NodeConfig#nodekubeletconfig
The text was updated successfully, but these errors were encountered: