Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable google_compute_router_nat.nat_ips to accept google_compute_address.id #6830

Closed

Comments

@edwardmedia
Copy link
Contributor

edwardmedia commented Jul 22, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently google_compute_router_nat.nat_ips only accept data formatting "https://www.googleapis.com/compute/v1/projects/REDACTED/regions/us-central1/addresses/prod-nat-manual-ip-0".
Make it accept
"projects/REDACTED/regions/us-central1/addresses/prod-nat-manual-ip-0" as well

This is related to an example in https://www.terraform.io/docs/providers/google/r/compute_router_nat.html

New or Affected Resource(s)

  • google_compute_router_nat

Potential Terraform Configuration

resource "google_compute_router_nat" "prod" {
  name                               = "prod-nat"
  router                             = google_compute_router.prod.name
  region                             = "us-central1"
  nat_ip_allocate_option             = "MANUAL_ONLY"
  nat_ips = google_compute_address.prod.*.self_link    <---- to accept google_compute_address.prod.*.id
  source_subnetwork_ip_ranges_to_nat = "ALL_SUBNETWORKS_ALL_IP_RANGES"
}

References

  • b/175129263
@ghost ghost added enhancement labels Jul 22, 2020
@edwardmedia edwardmedia changed the title google_compute_router_nat.nat_ips needs to accept google_compute_address.id enable google_compute_router_nat.nat_ips to accept google_compute_address.id Jul 22, 2020
@danawillow danawillow added this to the Goals milestone Jul 27, 2020
@rileykarson rileykarson modified the milestones: Goals, Near-Term Goals Dec 10, 2020
@ghost
Copy link

ghost commented Mar 29, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2021
@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-nat labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.