Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_compute_security_policy produces argument error when defining CloudArmor custom language #7005

Closed
RomTin opened this issue Aug 12, 2020 · 3 comments
Assignees
Labels

Comments

@RomTin
Copy link

RomTin commented Aug 12, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

terraform

%> terraform -v
Terraform v0.12.9

Your version of Terraform is out of date! The latest version
is 0.13.0. You can update by downloading from www.terraform.io/downloads.html

providers

Initializing provider plugins...
- Checking for available provider plugins...
- Downloading plugin for provider "google" (hashicorp/google) 2.20.3...
- Downloading plugin for provider "google-beta" (hashicorp/google-beta) 2.20.3...
- Downloading plugin for provider "template" (hashicorp/template) 2.1.2...

Affected Resource(s)

  • google_compute_security_policy

Terraform Configuration Files

resource "google_compute_security_policy" "web" {
  name = "web"

  rule {
    action   = "allow"
    priority = "1000"
    match {
      expr {
        expression = "inIpRange(origin.ip, '0.0.0.0/0')"
      }
    }
    description = "allow access from internet (example)"
  }

  rule {
    action   = "deny(503)"
    priority = "2147483647"
    match {
      versioned_expr = "SRC_IPS_V1"
      config {
        src_ip_ranges = ["*"]
      }
    }
    description = "default deny rule"
  }
}

Debug Output

Panic Output

Expected Behavior

google_compute_security_policy.web would be created

Actual Behavior

I got failure log.

Error: Missing required argument

  on cloudarmor.tf line 7, in resource "google_compute_security_policy" "web":
   7:     match {

The argument "versioned_expr" is required, but no definition was found.


Error: Unsupported block type

  on cloudarmor.tf line 8, in resource "google_compute_security_policy" "web":
   8:       expr {

Blocks of type "expr" are not expected here.

Steps to Reproduce

  1. terraform apply

Important Factoids

References

@ghost ghost added the bug label Aug 12, 2020
@edwardmedia edwardmedia self-assigned this Aug 12, 2020
@edwardmedia
Copy link
Contributor

@RomTin your code works for me except I have to replace "deny(503)" with "deny(403)". I notice that the version of your provider is pretty old (v2.20.3). Can you try to use the latest versions?

@RomTin
Copy link
Author

RomTin commented Aug 12, 2020

@edwardmedia
Thank you for your response!
I executed terraform apply with google provider v3.34.0, and found it produced an error "deny(503) can't be used in action"
which you pointed out, without argument error of expr.
Thus, the latest version of google provider worked properly.

It was very helpful in solving my question. Thank you very much!

@ghost ghost removed waiting-response labels Aug 12, 2020
@RomTin RomTin closed this as completed Aug 12, 2020
@ghost
Copy link

ghost commented Sep 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants