Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More service networking resources #7213

Closed
danawillow opened this issue Sep 8, 2020 · 7 comments
Closed

More service networking resources #7213

danawillow opened this issue Sep 8, 2020 · 7 comments

Comments

@danawillow
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

https://cloud.google.com/service-infrastructure/docs/service-networking/reference/rest/v1/services/addSubnetwork
There are a few others that appear in the discovery docs but not the website at the moment that I believe are also part of this request (roles, at least)

New or Affected Resource(s)

  • google_service_networking_X

References

  • b/167412924
@nma
Copy link
Contributor

nma commented Oct 9, 2020

I've started taking a look at this. If anyone has already taken a look would love to get in touch and share any findings.

@rileykarson
Copy link
Collaborator

Hey @nma! Did you ever end up taking a look at this?

@nma
Copy link
Contributor

nma commented Oct 26, 2020

Hey @rileykarson. I've started a branch on https://github.com/nma/terraform-provider-google-beta/tree/service-network-subnet

Currently testing a local build. This resource requires some org folder level permissions, so just in the midst of figuring out how to set that up and also translate it to a 'resource_x_test.go` format.

@rileykarson
Copy link
Collaborator

rileykarson commented Oct 26, 2020

Thanks! Marking you as assigned for our tracking purposes. Feel free to reach out if you run into any issues- the terraform-team group internally is the best way to reach the team.

@rileykarson
Copy link
Collaborator

I'm going to move this into sprints until it's resolved to reflect @nma and @ScottSuarez's ongoing work to get testing infrastructure set up.

@nma
Copy link
Contributor

nma commented Dec 7, 2020

The original customer that requested this feature has went with another solution. There is also no additional demand for the resource, so we can close this ticket for now.

I will keep my forked branches around for a few quarters in case there is more user demand to reopen this issue.

@ghost
Copy link

ghost commented Jan 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants