Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_storage_transfer_job -- notification_config field #7775

Closed
jcanseco opened this issue Nov 10, 2020 · 3 comments
Closed

google_storage_transfer_job -- notification_config field #7775

jcanseco opened this issue Nov 10, 2020 · 3 comments

Comments

@jcanseco
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

We'd like to request support for a notification_config field in google_storage_transfer_job to more closely reflect the API's TransferJob resource which supports a notificationConfig field.

New or Affected Resource(s)

  • google_storage_transfer_job

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

resource "google_storage_transfer_job" "transfer-job" {
    description = "Sample storage transfer job"
    transfer_spec {
        gcs_data_sink {
            bucket_name = "my-sink-bucket"
        }
        gcs_data_source {
            bucket_name = "my-source-bucket"
        }
    }
    schedule {
        schedule_start_date {
            year    = 2020
            month   = 1
            day     = 1
        }
    }
    notification_config {
        pubsub_topic = "projects/my-project/topics/my-topic"
        event_types = ["TRANSFER_OPERATION_SUCCESS", "TRANSFER_OPERATION_FAILED"]
        payload_format = "JSON"
   }
}

References

@ghost ghost added the enhancement label Nov 10, 2020
@rileykarson rileykarson added this to the Goals milestone Nov 16, 2020
@ct-dh
Copy link

ct-dh commented Mar 9, 2021

Any update on when this might be implemented? It seems a fairly small change in magic modules that would be quick to implement.

@hao-nan-li
Copy link
Collaborator

b/245746513

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants