providers/google: Support for Node Auto-Upgrade in google_container_cluster (GKE)

[hashibot]

This issue was originally opened by @cblecker as hashicorp/terraform#13391. It was migrated here as part of the provider split. The original body of the issue is below.

---

Relates to #44

Requesting support for node auto-upgrade on GKE clusters: https://cloud.google.com/container-engine/docs/node-auto-upgrade

cc: @danawillow @paddyforan

[stonith]

Also add to google_container_node_pool resource.

[danawillow]

Thanks! Linking to #93 so we can easily keep track of all the beta FRs.

[danawillow]

Fixed in #669

[petervandenabeele]

To make sure I understand. This original issue is/was called:

Support for Node Auto-Upgrade in *google_container_cluster*.

This issues is Closed, and the resolution is to add

Add support for *google_container_node_pool management*

However, the literal original question to allow "auto-upgrade" from the google_container_cluster resource was not fixed? I am now extracting my initial node specifications from code in a google_container_cluster to use the google_container_node_pool resource, because it looks like that is the only way to specify auto_upgrade = true.

It could still be useful to write something like this in the google_container_cluster resource:

  node_pool {
    management {                                                                       
       auto_upgrade = true                                                              
       auto_repair = true                                                               
     }
  }       

Do I understand the current status correctly?

Does my request make sense, or should we more early move to a google_container_node_pool when writing non-trivial google_container_cluster resources. Maybe in the docs of google_container_cluster we should write a hint that for more advanced node_pool configurations, it is required to set-up a separate google_container_node_pool resource ?

[danawillow]

Hi @petervandenabeele, the node_pool block in the google_container_cluster resource and the google_container_node_pool resource share all of the same properties, so you should be able to do what you're trying to do already.

However, I would recommend using google_container_node_pool resources anyway, unless you need the ability to specify the exact set of node pools that you want and guarantee that there are no others (see #1712 and some other issues in this repo for why I make that recommendation). The website hasn't been updated recently, but once it is, #2474 will show a warning about using node pools in the cluster resource.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!