Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_active_directory_domain authorized_networks should accept network self_link? #9546

Closed
alexjmoore opened this issue Jul 11, 2021 · 2 comments
Assignees
Labels

Comments

@alexjmoore
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.0.2
on linux_amd64

Affected Resource(s)

  • google_active_directory_domain

Terraform Configuration Files

resource "google_active_directory_domain" "ad-domain" {
  domain_name       = "ad1.example.com"
  locations         = ["europe-west2"]
  reserved_ip_range = "192.168.255.0/24"
  authorized_networks = [module.network["vpc-test"].network_self_link]
}

Expected Behavior

authorized_networks should accept the self_link of the network

Actual Behavior

authorized_networks appears to require the id of the network

References

See original issue raised to the Google network module team requesting that as a result of this resource needing id that could they make id an output, they seemed to suggest it best to raise a case here as self_link is more the typical reference to be passed and is already a top level output of the module:

See: terraform-google-modules/terraform-google-network#307

  • #0000
@alexjmoore alexjmoore added the bug label Jul 11, 2021
@edwardmedia edwardmedia self-assigned this Jul 12, 2021
@edwardmedia
Copy link
Contributor

@alecraso this is by design. There was an initiative inside the provider that changed the self_link to id

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants