Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating google_dns_record_set forces replacement of the resource instead of in-place update #9614

Closed
hatzibod opened this issue Jul 22, 2021 · 4 comments
Labels
bug persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work

Comments

@hatzibod
Copy link

hatzibod commented Jul 22, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

0.14.7

Affected Resource(s)

  • google_dns_record_set

Terraform Configuration Files

resource "google_dns_record_set" "test" {
  name         = "test.example.com."
  type         = "A"
  ttl          = 300
  managed_zone = google_dns_managed_zone.global.name
  rrdatas = [
    "10.0.0.1",
    "10.0.0.2"
  ]
}

Debug Output

Trace differences between version 3.63.0 and newer versions:

https://gist.github.com/hatzibod/0608b58b8fabd80bfbd7288f738ffc5d

Expected Behavior

Updating rrdatas should be an in-place change.

Actual Behavior

The resource is being deleted and a new one is being created.

Steps to Reproduce

  1. Create a resource. (terraform apply)
  2. Then add/remove an IP
  3. Run terraform apply

This change was introduced in 3.64.0.

@hatzibod hatzibod added the bug label Jul 22, 2021
@edwardmedia
Copy link
Contributor

edwardmedia commented Jul 22, 2021

Related to #9416. Add label of persistent-bug

@edwardmedia edwardmedia added the persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work label Jul 22, 2021
@Sytten
Copy link

Sytten commented Aug 4, 2021

Is it possible to get some priority on this bug, seems like there are a few issues related to that problem and it is known since may :/

@roaks3
Copy link
Collaborator

roaks3 commented Oct 8, 2022

This was happening because rrdatas was set to ForceNew, but that behavior has since been reverted with GoogleCloudPlatform/magic-modules#5191, and updates should now be happening in-place.

@roaks3 roaks3 closed this as completed Oct 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work
Projects
None yet
Development

No branches or pull requests

4 participants