Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updateMask for google_logging_project_sink update #991

Closed
ctavan opened this issue Jan 22, 2018 · 1 comment
Closed

Use updateMask for google_logging_project_sink update #991

ctavan opened this issue Jan 22, 2018 · 1 comment
Assignees

Comments

@ctavan
Copy link
Contributor

ctavan commented Jan 22, 2018

While implementing logging exclusions in #990 I came across a note in https://cloud.google.com/logging/docs/reference/v2/rest/v2/projects.sinks/patch which states:

An empty updateMask is temporarily treated as using the following mask for backwards compatibility purposes: destination,filter,includeChildren At some point in the future, behavior will be removed and specifying an empty updateMask will be an error.

Maybe this should be updated in the terraform Google provider before the API changes?

@ghost
Copy link

ghost commented Nov 17, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants