From e07c1f051f753f77ada53d2a2e1f176e9e059e3e Mon Sep 17 00:00:00 2001 From: Modular Magician Date: Fri, 8 Jul 2022 16:43:01 +0000 Subject: [PATCH] make provisioned_iops Computed true (#6222) * make provisioned_iops Computed true * update test case name Co-authored-by: Edward Sun Signed-off-by: Modular Magician --- .changelog/6222.txt | 3 +++ google/resource_compute_disk.go | 1 + google/resource_compute_disk_test.go | 31 ++++++++++++++++++++++++++++ 3 files changed, 35 insertions(+) create mode 100644 .changelog/6222.txt diff --git a/.changelog/6222.txt b/.changelog/6222.txt new file mode 100644 index 00000000000..b64fa439f71 --- /dev/null +++ b/.changelog/6222.txt @@ -0,0 +1,3 @@ +```release-note:bug +compute: fixed force recreation on `provisioned_iops` of `google_compute_disk` +``` diff --git a/google/resource_compute_disk.go b/google/resource_compute_disk.go index 293e6d3252c..a7d1f8e002c 100644 --- a/google/resource_compute_disk.go +++ b/google/resource_compute_disk.go @@ -363,6 +363,7 @@ the supported values for the caller's project.`, }, "provisioned_iops": { Type: schema.TypeInt, + Computed: true, Optional: true, ForceNew: true, Description: `Indicates how many IOPS must be provisioned for the disk.`, diff --git a/google/resource_compute_disk_test.go b/google/resource_compute_disk_test.go index f8ca7b64dff..881e760996f 100644 --- a/google/resource_compute_disk_test.go +++ b/google/resource_compute_disk_test.go @@ -437,6 +437,27 @@ func TestAccComputeDisk_deleteDetachIGM(t *testing.T) { }) } +func TestAccComputeDisk_pdExtremeImplicitProvisionedIops(t *testing.T) { + t.Parallel() + + diskName := fmt.Sprintf("tf-test-%s", randString(t, 10)) + + vcrTest(t, resource.TestCase{ + PreCheck: func() { testAccPreCheck(t) }, + Providers: testAccProviders, + Steps: []resource.TestStep{ + { + Config: testAccComputeDisk_pdExtremeImplicitProvisionedIops(diskName), + }, + { + ResourceName: "google_compute_disk.foobar", + ImportState: true, + ImportStateVerify: true, + }, + }, + }) +} + func testAccCheckComputeDiskExists(t *testing.T, n, p string, disk *compute.Disk) resource.TestCheckFunc { return func(s *terraform.State) error { rs, ok := s.RootModule().Resources[n] @@ -722,3 +743,13 @@ resource "google_compute_instance_group_manager" "manager" { } `, diskName, mgrName) } + +func testAccComputeDisk_pdExtremeImplicitProvisionedIops(diskName string) string { + return fmt.Sprintf(` +resource "google_compute_disk" "foobar" { + name = "%s" + type = "pd-extreme" + size = 1 +} +`, diskName) +}