diff --git a/.changelog/8845.txt b/.changelog/8845.txt new file mode 100644 index 00000000000..ab85557eafe --- /dev/null +++ b/.changelog/8845.txt @@ -0,0 +1,3 @@ +```release-note:enhancement +logging: supported in-place update for `unique_writer_identity` in `google_logging_project_sink` +``` diff --git a/google/services/logging/resource_logging_project_sink.go b/google/services/logging/resource_logging_project_sink.go index 18391398364..d3d6780b1e1 100644 --- a/google/services/logging/resource_logging_project_sink.go +++ b/google/services/logging/resource_logging_project_sink.go @@ -39,7 +39,6 @@ func ResourceLoggingProjectSink() *schema.Resource { Type: schema.TypeBool, Optional: true, Default: false, - ForceNew: true, Description: `Whether or not to create a unique identity associated with this sink. If false (the default), then the writer_identity used is serviceAccount:cloud-logs@system.gserviceaccount.com. If true, then a unique service account is created and used for this sink. If you wish to publish logs across projects, you must set unique_writer_identity to true.`, } return schm diff --git a/google/services/logging/resource_logging_project_sink_test.go b/google/services/logging/resource_logging_project_sink_test.go index 443ee49da7f..aba5290745e 100644 --- a/google/services/logging/resource_logging_project_sink_test.go +++ b/google/services/logging/resource_logging_project_sink_test.go @@ -335,7 +335,7 @@ resource "google_logging_project_sink" "described" { filter = "logName=\"projects/%s/logs/compute.googleapis.com%%2Factivity_log\" AND severity>=ERROR" description = "description updated" - unique_writer_identity = false + unique_writer_identity = true } resource "google_storage_bucket" "log-bucket" { @@ -470,7 +470,7 @@ resource "google_logging_project_sink" "bigquery" { destination = "bigquery.googleapis.com/projects/%s/datasets/${google_bigquery_dataset.logging_sink.dataset_id}" filter = "logName=\"projects/%s/logs/compute.googleapis.com%%2Factivity_log\" AND severity>=WARNING" - unique_writer_identity = false + unique_writer_identity = true } resource "google_bigquery_dataset" "logging_sink" {