Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo preventing the use of KUBE_PROXY_URL env variable #2485

Merged
merged 2 commits into from
May 8, 2024

Conversation

alexsomesan
Copy link
Member

Description

Fixes a typo that was shadowing the value extracted from the KUBE_PROXY_URL env var, preventing it from being used in client configuration.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Fixes #1733

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@alexsomesan alexsomesan marked this pull request as ready for review May 8, 2024 12:02
@alexsomesan alexsomesan requested a review from a team as a code owner May 8, 2024 12:02
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@alexsomesan alexsomesan merged commit 17763a5 into main May 8, 2024
37 checks passed
@alexsomesan alexsomesan deleted the fix-proxy-url branch May 8, 2024 12:46
dduportal referenced this pull request in jenkins-infra/azure May 10, 2024
<Actions>
<action
id="bcd9b70d7c1eb1e07eb5ad8a958f18dc1bbd81461ee1a2604adeea46e3148a47">
        <h3>Bump Terraform `kubernetes` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/kubernetes&#34; updated
from &#34;2.29.0&#34; to &#34;2.30.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.30.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v2.30.0&#xA;BUG
FIXES:&#xD;&#xA;&#xD;&#xA;* `data_source/kubernetes_resources`: fix an
issue where the provider exit with an error when the data source
`kubernetes_resources` receives multiple Kubernetes objects containing
tuples with different numbers of elements.
[[GH-2372](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2372)]&#xD;&#xA;*
`kubernetes_manifest`: fix issue preventing KUBE_PROXY_URL environment
variable from being used in client configuration (#1733)
[[GH-2485](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2485)]&#xD;&#xA;*
`resource/kubernetes_node_taint`: Fix the error check for nonexistant
nodes so that terraform does not fail if there is a taint in the state
file for a node that has been deleted.
[[GH-2402](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2402)]&#xD;&#xA;&#xD;&#xA;DOCS:&#xD;&#xA;&#xD;&#xA;*
Migrate legacy structure to new tfplugindocs template structure
[[GH-2470](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2470)]&#xD;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/161/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes_manifest might not be respecting KUBE_PROXY_URL
2 participants