Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate signing request expiration seconds #2559

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jul 24, 2024

wrapping up #2515

Original Description

Description

I saw that expirationSeconds wasn't available through this provider.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run="(TestAccKubernetesCertificateSigningRequestV1_basic|TestAccKubernetesCertificateSigningRequestV1_generateName)"'
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/home/moritz/dev/terraform-provider-kubernetes/add-fields-to-certificate-signing-request/kubernetes" -v -vet=off -run="(TestAccKubernetesCertificateSigningRequestV1_basic|TestAccKubernetesCertificateSigningRequestV1_generateName)" -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesCertificateSigningRequestV1_basic
=== PAUSE TestAccKubernetesCertificateSigningRequestV1_basic
=== RUN   TestAccKubernetesCertificateSigningRequestV1_generateName
=== PAUSE TestAccKubernetesCertificateSigningRequestV1_generateName
=== CONT  TestAccKubernetesCertificateSigningRequestV1_basic
=== CONT  TestAccKubernetesCertificateSigningRequestV1_generateName
--- PASS: TestAccKubernetesCertificateSigningRequestV1_generateName (3.42s)
--- PASS: TestAccKubernetesCertificateSigningRequestV1_basic (3.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-kubernetes/kubernetes	(cached)

Release Note

Release note for CHANGELOG:

`resource/kubernetes_certificate_signing_request_v1`: Add argument `spec.expiration_seconds`

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from a team as a code owner July 24, 2024 18:22
@BBBmau BBBmau force-pushed the certificate-signing-request-expiration-seconds branch from 547aaa6 to 51559c5 Compare July 25, 2024 01:20
@github-actions github-actions bot added size/S and removed size/XL labels Jul 25, 2024
@BBBmau BBBmau added the no-documentation This issue or pull request does not have documentation changes. label Jul 25, 2024
@BBBmau
Copy link
Contributor Author

BBBmau commented Jul 25, 2024

the no documentation label is just to cancel the Document Updates workflow that will need to be addressed in a separate PR.

@BBBmau
Copy link
Contributor Author

BBBmau commented Jul 25, 2024

Thanks for contributing! @moreinhardt

@BBBmau BBBmau merged commit ef67d17 into main Jul 25, 2024
20 of 21 checks passed
@BBBmau BBBmau deleted the certificate-signing-request-expiration-seconds branch July 25, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation no-documentation This issue or pull request does not have documentation changes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants