Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Copy for schema.ProviderSchema #44

Merged
merged 1 commit into from
May 22, 2021
Merged

Implement Copy for schema.ProviderSchema #44

merged 1 commit into from
May 22, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented May 17, 2021 •
edited
Loading

This follows hashicorp/hcl-lang#40 - the same "Why" and "Implementation Notes" apply here also.

This will help address hashicorp/terraform-ls#509

@radeksimko radeksimko mentioned this pull request May 17, 2021
Merged
@radeksimko radeksimko requested a review from a team May 17, 2021 20:12
aeschright
aeschright approved these changes May 21, 2021
View reviewed changes
Copy link

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit 0f5e258 into main May 22, 2021
@radeksimko radeksimko deleted the f-copy-funcs branch May 22, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @aeschright