[aws] Expose RDS DB Instance HostedZoneId attribute

[freeman]

The RDS API exposes a HostedZoneId through its endpoint property (when doing DescribeDbInstance).

This pull requests makes it available to terraform as an exported attribute so it can be used in route53 for example.

[stack72]

Hi @freeman

Congratulations on opening issue #10000 :) For that you win a prize (kidding, there is no prize!)

Thanks for the PR here. Is there anything you need done to get this merged? Is this ready?

Paul

[freeman]

🌟 for #10000 :)

However I'll shame myself for life saying that I did not test this locally and coded it blindly. My current environment does not allow me to test it easily (the hard part being building terraform on my windows machine).

If you feel the change is minor enough to be merged without more tests than what is performed by travis-ci this would be great. If you'd like a feedback on using it for real before merging (which I would totally expect) give me a few days to provide it.

❤️ to the HashiCorp team for your products and responsiveness.

[stack72]

Haha ok I can test this for you in the morning (I'm in UK).if there are any issues I'll ping ya

Thanks for the work!

[stack72]

Hey @freeman

Just a FYI - I tested this and it works :) Renamed the parameter from zone_id to hosted_zone_id and added a test to make sure the value was set e029608

Thanks so much for all the work here!

Paul

[freeman]

Thanks !

I used zone_id to be consistent with the elb resource but I agree that being close to the API is better.

Le 10 nov. 2016 à 07:45, Paul Stack notifications@github.com a écrit :

Hey @freeman

Just a FYI - I tested this and it works :) Renamed the parameter from zone_id to hosted_zone_id and added a test to make sure the value was set e029608

Thanks so much for all the work here!

Paul

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.