helper/shadow: Close for auto-closing all values #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
force-pushed
the
b-shadow-close
branch
from
34aff94 to
3c339ee
Compare
jbardin
approved these changes
Nov 15, 2016
| return nil | ||
| } | ||
|
|
||
| var closer io.Closer |
There was a problem hiding this comment.
don't need the declaration here, with the := below
Fixes #10122 The simple fix was that we forgot to close `ReadDataApply` for the provider. But I've always felt that this section of the code was brittle and I wanted to put in a more robust solution. The `shadow.Close` method uses reflection to automatically close all values.
mitchellh
force-pushed
the
b-shadow-close
branch
from
3c339ee to
6557a3d
Compare
|
Good catch. Fixed, merging. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10122
The simple fix was that we forgot to close
ReadDataApplyfor theprovider. But I've always felt that this section of the code was brittle
and I wanted to put in a more robust solution. The
shadow.Closemethoduses reflection to automatically close all values.